Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web of Things (WoT) Thing Description #357

Closed
3 of 5 tasks
mmccool opened this issue Mar 26, 2019 · 11 comments
Closed
3 of 5 tasks

Web of Things (WoT) Thing Description #357

mmccool opened this issue Mar 26, 2019 · 11 comments
Assignees
Labels
Mode: breakout Work done during a time-limited breakout session Priority: urgent Venue: Web of Things WG

Comments

@mmccool
Copy link

mmccool commented Mar 26, 2019

Góðan dag TAG!

I'm requesting a TAG review of:

Further details (optional):

You should also know that...

In the Thing Description specification, text and table entries highlighted with a yellow background indicates a feature associated with an at-risk assertion for which insufficient implementation experience exists. When an entire section is at-risk the words "This section is at risk." will be placed at the start of the section and highlighted with a yellow background.

During the TAG review period, we plan to update the test results to reduce the number of at-risk assertions as much as possible before CR submission. The link above refers to the master branch of the repository, not the TAG-review branch.

We'd prefer the TAG provide feedback as (please select one):

  • open issues in our Github repo for each point of feedback
  • open a single issue in our Github repo for the entire review
  • leave review feedback as a comment in this issue and @-notify [github usernames]
mmccool added a commit to w3c/wot-thing-description that referenced this issue Mar 26, 2019
- Change link to explainer to refer to the TAG-review branch
- Add a note that the "Test" link intentionally refers to the master branch, not the TAG-review branch
This matches what is at w3ctag/design-reviews#357
@mmccool mmccool changed the title Web of Things (WoT) Thing Description TAG review request: Web of Things (WoT) Thing Description Mar 26, 2019
@plinss plinss changed the title TAG review request: Web of Things (WoT) Thing Description Web of Things (WoT) Thing Description Mar 26, 2019
@cynthia
Copy link
Member

cynthia commented Mar 26, 2019

Both the spec review and explainer 404 to me.

@sebastiankb
Copy link

The template points to outdated links. Sorry for that.

Please use for the TD spec: https://cdn.staticaly.com/gh/w3c/wot-thing-description/TD-TAG-review/index.html?env=dev

For the explainer: https://github.com/w3c/wot-thing-description/blob/TD-TAG-review/explainer/Explainer.md

@mmccool Please update the links in the template above.

@mmccool
Copy link
Author

mmccool commented Mar 27, 2019

Links fixed.

@takuki
Copy link

takuki commented Apr 12, 2019

Made a clarification about TD serialization.
The Thing Description document was updated.
(No change to the URL of the document)

This happened on 4/12 Friday. Noon in US Pacific time, 21:00 in Central Europe, 3am on 4/13 in China.
Please be aware of the time of the change if you already started to review.

This is in order to avoid giving an unintended impression to reviewers that TD has more than one serializations. TD has only one serialization format that conforms to JSON-LD 1.1.

@sebastiankb
Copy link

I would just like to mention that we have an updated TD draft that can be found in the master branch:

Latest TD Specification

This version has already compiled some I18N aspects, clearer explanations of some features, typo fixes, etc..

@ashimura
Copy link

@ylafon and @torgo we've been wondering about the final review results from the TAG, because we're planning to publish the update drafts as Proposed Recommendations on June 27th and want (wanted) to send out transition requests for the WoT Thing Description (and the WoT Architecture) today on June 20.

When I talked with @ylafon about the possible review results, he mentioned there would not be many comments in any case. So I'd like to confirm there would not be blocking comments for our Proposed Recommendation transition.

@dbaron
Copy link
Member

dbaron commented Jun 20, 2019

I have some comments that I will try to write up on Monday.

@ashimura
Copy link

Thanks a lot, @dbaron !

@dbaron
Copy link
Member

dbaron commented Jul 11, 2019

(the discussion has ended up mostly in #355 rather than here)

@kenchris
Copy link

It is common that explainers have a section listing some of the other solutions that were considered and rejected. This really helps us understand why the chosen solution is better and how you have learned from existing and prior solutions.

@hadleybeeman
Copy link
Member

Our feedback is primarily in architecture, in our issue 355. We are happy to close this now.

@rhiaro rhiaro added Mode: breakout Work done during a time-limited breakout session and removed Big chunk of work labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mode: breakout Work done during a time-limited breakout session Priority: urgent Venue: Web of Things WG
Projects
None yet
Development

No branches or pull requests