Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

다른 기기에서 시간표 삭제 시 404 대응 #226

Merged
merged 2 commits into from
Oct 8, 2023

Conversation

eastshine2741
Copy link
Collaborator

A기기의 현재 선택된 시간표를 B기기에서 삭제할 경우, A기기에서 앱을 켜면 404에러가 발생한다. 그러나 별도의 에러메시지가 출력되지 않고, 올바른 시간표를 다시 가져오지 않아 강의 추가 등을 할 경우 404 에러가 계속해서 발생했다.

try catch로 감싸서 대응했다. runCatching을 쓰려 했는데, 단순한 코드고 굳이 Result 객체를 만들 필요가 없어보여서 try catch로 했다
runCatching으로 더 이쁘게 할 수 있나..?

@eastshine2741 eastshine2741 requested a review from a team as a code owner October 4, 2023 01:23
Copy link
Member

@woohm402 woohm402 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 코틀린 코드 거의 처음 보는데 코드 되게 타입스크립트랑 비슷하게생겼다 신기

엄청 다른줄

Copy link
Collaborator

@JuTaK97 JuTaK97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

낫배드한듯

@eastshine2741 eastshine2741 force-pushed the eastshine2741/fix-timetable-404 branch from e70fed5 to c01ff92 Compare October 8, 2023 13:36
@eastshine2741 eastshine2741 merged commit a2d5f25 into develop Oct 8, 2023
3 checks passed
@eastshine2741 eastshine2741 deleted the eastshine2741/fix-timetable-404 branch October 8, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants