Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): peer/subscription renewal with recurring Filter pings #2052

Merged
merged 15 commits into from
Jul 10, 2024

Conversation

danisharora099
Copy link
Collaborator

Problem

When using the Filter protocol, we create subscriptions with multiple peers. This increases the inherent reliability considering we have multiple nodes that can provide us with an incoming Filter messages. To continue this effort, it is helpful to be able to observe the nodes that are not as reliable specifically, and act on renewing them with potentially healthy peers.

Solution

As part of increasing reliability for Filter, doing recurring Filter pings on nodes with whom we have open subscriptions and expect incoming Filter messages from:

  • individually do Filter pings to all the peers
  • in case Filter ping with an invidividual node continues to fail, disconnect with that peer & connect to a new peer
  • initiate the same Filter subscription with the new peer

Notes

Contribution checklist:

  • covered by unit tests;
  • covered by e2e test;
  • add ! in title if breaks public API;

@danisharora099 danisharora099 requested a review from a team as a code owner July 3, 2024 07:39
@danisharora099 danisharora099 force-pushed the feat/filter-renew-peers branch from bffda11 to da6cd5f Compare July 3, 2024 07:40
@danisharora099 danisharora099 changed the title feat(filter): peer renewal with recurring Filter pings feat(filter): peer/subscription renewal with recurring Filter pings Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 183.39 KB (+0.12% 🔺) 3.7 s (+0.12% 🔺) 4.5 s (-24.13% 🔽) 8.2 s
Waku Simple Light Node 183.42 KB (+0.14% 🔺) 3.7 s (+0.14% 🔺) 5.6 s (+20.55% 🔺) 9.3 s
ECIES encryption 23.12 KB (0%) 463 ms (0%) 1.9 s (+80.77% 🔺) 2.3 s
Symmetric encryption 22.58 KB (0%) 452 ms (0%) 1.7 s (+30.86% 🔺) 2.2 s
DNS discovery 72.49 KB (0%) 1.5 s (0%) 4.3 s (+26.01% 🔺) 5.7 s
Peer Exchange discovery 74.15 KB (0%) 1.5 s (0%) 3 s (+33.66% 🔺) 4.5 s
Local Peer Cache Discovery 67.68 KB (0%) 1.4 s (0%) 2.3 s (-8.16% 🔽) 3.7 s
Privacy preserving protocols 38.87 KB (0%) 778 ms (0%) 2.8 s (+61.86% 🔺) 3.5 s
Waku Filter 112.85 KB (+0.18% 🔺) 2.3 s (+0.18% 🔺) 3.3 s (+4.11% 🔺) 5.5 s
Waku LightPush 111.31 KB (+0.19% 🔺) 2.3 s (+0.19% 🔺) 5.3 s (+51.34% 🔺) 7.5 s
History retrieval protocols 111.61 KB (-0.05% 🔽) 2.3 s (-0.05% 🔽) 4.7 s (+19.07% 🔺) 6.9 s
Deterministic Message Hashing 7.29 KB (0%) 146 ms (0%) 468 ms (-20.95% 🔽) 614 ms

@danisharora099 danisharora099 requested a review from weboko July 3, 2024 13:19
Copy link
Collaborator

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything else seems fine

@danisharora099 danisharora099 force-pushed the feat/filter-renew-peers branch from 1267f5d to 3516b43 Compare July 10, 2024 08:52
@danisharora099 danisharora099 merged commit 318667e into master Jul 10, 2024
10 of 11 checks passed
@danisharora099 danisharora099 deleted the feat/filter-renew-peers branch July 10, 2024 10:04
@weboko weboko mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants