From 8c568cabbeaf4da782fed1d43c62e432c68d3ecb Mon Sep 17 00:00:00 2001
From: Aaryamann Challani <43716372+rymnc@users.noreply.github.com>
Date: Wed, 16 Aug 2023 19:00:10 +0530
Subject: [PATCH] fix(rln-relay): should error out on rln-relay mount failure
 (#1904)

---
 waku/node/waku_node.nim | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/waku/node/waku_node.nim b/waku/node/waku_node.nim
index 57d0d7a848..6720e408df 100644
--- a/waku/node/waku_node.nim
+++ b/waku/node/waku_node.nim
@@ -663,8 +663,7 @@ when defined(rln):
     info "mounting rln relay"
 
     if node.wakuRelay.isNil():
-      error "WakuRelay protocol is not mounted, cannot mount WakuRlnRelay"
-      return
+      raise newException(CatchableError, "WakuRelay protocol is not mounted, cannot mount WakuRlnRelay")
     # TODO: check whether the pubsub topic is supported at the relay level
     # if rlnConf.rlnRelayPubsubTopic notin node.wakuRelay.defaultPubsubTopics:
     #   error "The relay protocol does not support the configured pubsub topic for WakuRlnRelay"
@@ -672,8 +671,7 @@ when defined(rln):
     let rlnRelayRes = await WakuRlnRelay.new(rlnConf,
                                              registrationHandler)
     if rlnRelayRes.isErr():
-      error "failed to mount WakuRlnRelay", error=rlnRelayRes.error
-      return
+      raise newException(CatchableError, "failed to mount WakuRlnRelay: {rlnRelayRes.error}")
     let rlnRelay = rlnRelayRes.get()
     let validator = generateRlnValidator(rlnRelay, spamHandler)
     let pb = PubSub(node.wakuRelay)