feat(rln-relay): pass in index to keystore credentials #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpavlin
reviewed
Jun 6, 2023
| @@ -51,7 +51,7 @@ procSuite "WakuNode - RLN relay": | |||
| await node1.mountRlnRelay(WakuRlnConfig(rlnRelayDynamic: false, | |||
| rlnRelayPubsubTopic: rlnRelayPubSubTopic, | |||
| rlnRelayContentTopic: contentTopic, | |||
| rlnRelayMembershipIndex: some(MembershipIndex(1)), | |||
| rlnRelayCredIndex: MembershipIndex(1), | |||
There was a problem hiding this comment.
Would it make sense to also rename the type MembershipIndex?
There was a problem hiding this comment.
This looks like it fell through the sieve, it should actually be <index>.uint instead. fixed in 956a63c
vpavlin
approved these changes
Jun 6, 2023
Ivansete-status
approved these changes
Jun 6, 2023
alrevuelta
approved these changes
Jun 6, 2023
jm-clius
approved these changes
Jun 6, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows users/operators to pass in the index of credentials to use. "Credentials" represents the keystore provided by the
waku_keystoremodule.Changes
s/rlnRelayMembershipIndex/rlnRelayCredIndex/gto be more descriptive--rln-relay-membership-group-index) to chat2 and wakunode2 to allow operators toselect the credential within a an array of
credentials in rln app
Issue
closes #1774