Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rln-relay): tree race condition upon initialization #1807

Merged
merged 1 commit into from
Jun 19, 2023
Merged

fix(rln-relay): tree race condition upon initialization #1807

merged 1 commit into from
Jun 19, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Jun 16, 2023 •
edited
Loading

Description

Resolves the race condition in the tests other than static group manager. Thanks for the report @Ivansete-status

Changes

  • Updates tree_path in onchain, waku_rln_relay tests

@rymnc rymnc self-assigned this Jun 17, 2023
@rymnc rymnc linked an issue Jun 17, 2023 that may be closed by this pull request
chore: test_rln_group_manager_static.nim fails randomly #1796
Closed
@rymnc rymnc marked this pull request as ready for review June 17, 2023 05:38
@rymnc rymnc requested a review from Ivansete-status June 17, 2023 05:38
Ivansete-status
Ivansete-status approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@rymnc rymnc merged commit f8e270f into master Jun 19, 2023
@rymnc rymnc deleted the fix-rln-test branch June 19, 2023 08:16
SionoiS pushed a commit that referenced this pull request Jun 19, 2023
@rymnc @SionoiS
fix(rln-relay): tree race condition upon initialization (#1807)
1b7ff55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

Assignees

@rymnc rymnc

Labels
None yet
Projects
Waku
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: test_rln_group_manager_static.nim fails randomly
2 participants
@rymnc @Ivansete-status