Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: RLN validator is only added for statically configured pubsub topics #2365

Closed
gabrielmer opened this issue Jan 23, 2024 · 0 comments · Fixed by #2367
Closed

bug: RLN validator is only added for statically configured pubsub topics #2365

gabrielmer opened this issue Jan 23, 2024 · 0 comments · Fixed by #2367
Assignees
Labels
bug Something isn't working critical This issue needs critical attention

Comments

@gabrielmer
Copy link
Contributor

Problem

Currently, when RLN is enabled, RLN validator is added only for pubsub topics added at node initialization

node.wakuRelay.addValidator(pubsubTopic, validator)

For dynamically added topics, RLN validator is not set even if node is running with RLN enabled.

In go-waku, if rln is enabled the RLN validator is added to defaultTopicValidators which are set to any pubsubTopics subscribed after initialization:

Expected behavior

If RLN is enabled in the node, all the pubsub topics must run the RLN validator

@gabrielmer gabrielmer added bug Something isn't working critical This issue needs critical attention labels Jan 23, 2024
@chair28980 chair28980 moved this to Priority in Waku Jan 23, 2024
@gabrielmer gabrielmer moved this from Priority to In Progress in Waku Jan 23, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Waku Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical This issue needs critical attention
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant