fix(bindings): base64 payload and key for content topic #2435
Conversation
|
You can find the image built from this PR at Built from 3fed8ac |
richard-ramos
requested review from
Ivansete-status,
SionoiS and
NagyZoltanPeter
richard-ramos
force-pushed
the
chore/bindings
branch
2 times, most recently
from
3b78991 to
0c34551
Compare
| proc toWakuMessage*(self: JsonMessage): WakuMessage = | ||
| let payloadRes = base64.decode(self.payload) | ||
| if payloadRes.isErr(): | ||
| raise newException(ValueError, "invalid payload format: " & payloadRes.error) |
There was a problem hiding this comment.
Nitpick, if possible I'd avoid using exceptions:)
There was a problem hiding this comment.
Replaced by a Result in a4f7b88
| version: uint32(self.version), | ||
| timestamp: self.timestamp, | ||
| ephemeral: self.ephemeral | ||
| ) |
There was a problem hiding this comment.
At first sight I missed having the rln proof but I believe this is something we will add in the future when we expose some kind of publish_rln function
There was a problem hiding this comment.
Ended up adding the proof in a4f7b88 so it's now 'future-ready' for when we include rln functionality to bindings
library/libwaku.nim
Outdated
| @@ -43,14 +45,14 @@ const RET_MISSING_CALLBACK: cint = 2 | |||
| proc relayEventCallback(ctx: ptr Context): WakuRelayHandler = | |||
| return proc (pubsubTopic: PubsubTopic, msg: WakuMessage): Future[system.void]{.async.} = | |||
| # Callback that hadles the Waku Relay events. i.e. messages or errors. | |||
| if not isNil(ctx[].eventCallback): | |||
| if not isNil(ctx[].eventCallback) and not isNil(ctx[].eventUserData): | |||
There was a problem hiding this comment.
Given that we now have two conditions that should be met, I wonder if we could split the validation in two, and apply some kind of "return early pattern". The following article explains the idea much better:
https://medium.com/swlh/return-early-pattern-3d18a41bba8
lmk what do you think :)
There was a problem hiding this comment.
Sounds good! I removed the validation from the if and executed those following the 'return early' pattern as described in the article you shared.
a4f7b88
richard-ramos
force-pushed
the
chore/bindings
branch
from
2e18057 to
a4f7b88
Compare
Description
Various fixes to the bindings to issues identified while attempting to integrate nwaku with waku-rust-bindings
Changes
waku_set_event_callbackis invokedcontentTopicinstead ofcontent_topicin the message JSON