Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rest): add ephemeral field support. #2525

Merged
merged 1 commit into from
Mar 13, 2024
Merged

feat(rest): add ephemeral field support. #2525

merged 1 commit into from
Mar 13, 2024

Conversation

richard-ramos
Copy link
Member

Description

Adds support to use the ephemeral field in the Waku messages with REST api as described in waku-org/waku-rest-api#2

Issue

closes #2436

@richard-ramos richard-ramos self-assigned this Mar 11, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2525-rln-v2-false

Built from b0b6096

@richard-ramos richard-ramos force-pushed the fix-ephemeral-rest branch 3 times, most recently from 63834ba to ade2f22 Compare March 12, 2024 02:48
SionoiS
SionoiS approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@Ivansete-status
Copy link
Collaborator

Ivansete-status commented Mar 12, 2024 •
edited
Loading

Thanks for that @richard-ramos !
I haven't checked it carefully but it seems a test needs to be adapted:
image

To run that particular test:

  1. source env.sh
  2. nim c -r -d:chronicles_log_level=DEBUG -d:release -d:postgres -d:rln --passL:librln_v0.3.4.a --passL:-lm -d:nimDebugDlOpen ./tests/wakunode_rest/test_rest_relay.nim test "Get the latest messages for a pubsub topic - GET /relay/v1/messages/{topic}"

@richard-ramos
Copy link
Member Author

@Ivansete-status thank you! :) PR is green now!

NagyZoltanPeter
NagyZoltanPeter approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Also was dare to merge that half y old PR into waku-rest-api repo: waku-org/waku-rest-api#2

@richard-ramos richard-ramos merged commit c734f60 into master Mar 13, 2024
14 of 15 checks passed
@richard-ramos richard-ramos deleted the fix-ephemeral-rest branch March 13, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NagyZoltanPeter NagyZoltanPeter NagyZoltanPeter approved these changes

@SionoiS SionoiS SionoiS approved these changes

@gabrielmer gabrielmer Awaiting requested review from gabrielmer

@Ivansete-status Ivansete-status Awaiting requested review from Ivansete-status

Assignees

@richard-ramos richard-ramos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: relay publish fails with 400 Bad Request when message contains ephemeral field
4 participants
@richard-ramos @Ivansete-status @SionoiS @NagyZoltanPeter