chore: Minor enhancements #2789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This counts the number of rows with "select count(1) from messages" which is quite intense and we shouldn't run it every minute
|
This PR may contain changes to configuration options of one of the apps. If you are introducing a breaking change (i.e. the set of options in latest release would no longer be applicable) make sure the original option is preserved with a deprecation note for 2 following releases before it is actually removed. Please also make sure the label |
|
You can find the image built from this PR at Built from b05fdb8 |
SionoiS
approved these changes
Jun 7, 2024
NagyZoltanPeter
approved these changes
Jun 7, 2024
darshankabariya
pushed a commit
that referenced
this pull request
Jun 11, 2024
* archive.nim: reduce the database report interval from 1 to 30 min This counts the number of rows with "select count(1) from messages" which is quite intense and we shouldn't run it every minute * aside cleanup
rymnc
pushed a commit
that referenced
this pull request
Jun 20, 2024
* archive.nim: reduce the database report interval from 1 to 30 min This counts the number of rows with "select count(1) from messages" which is quite intense and we shouldn't run it every minute * aside cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main purpose of this PR is to reduce the number of
SELECT count(*) FROM MESSAGESqueries that we make to the databases.Aside from that, I'm just removing some minor leftovers.