chore(keystore): verbose error message when credential is not found #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @romanzac for this report |
rymnc
force-pushed
the
verbose-error-message
branch
from
18538c7 to
b66f067
Compare
|
You can find the image built from this PR at Built from 68ce8d5 |
Ivansete-status
approved these changes
Aug 1, 2024
alrevuelta
approved these changes
Aug 5, 2024
|
@Ivansete-status is this okay to merge? some filter related CI is failing |
Sorry for delay. It is okay to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some verbose logging when a keystore has multiple credentials, but the
rlnRelayCredIndexis not passed in to find the unique credential. The error log now has some indication of what should be done to fix it, rather than just sayingcredential not found.Changes
waku_keystore.KeystoreCredentialNotFoundErrorHow to test
rlnKeystoreGeneratormultiple times for the same keystorewakunode2:./build/wakunode2 --cluster-id:1 --rln-relay-cred-path:rlnKeystore.json --rln-relay-eth-client-address:https://eth-sepolia.g.alchemy.com/v2/<YOUR_API_KEY> --rln-relay-cred-password:password