Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rln-relay): bump zerokit to v0.3.2 #1951

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix(rln-relay): bump zerokit to v0.3.2 #1951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
path = vendor/zerokit
url = https://github.com/vacp2p/zerokit.git
ignore = dirty
branch = v0.3.1
branch = v0.3.2
[submodule "vendor/nim-regex"]
path = vendor/nim-regex
url = https://github.com/nitely/nim-regex.git
Expand Down
2 changes: 1 addition & 1 deletion scripts/build_rln.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ fi
host_triplet=$(rustup show | grep "Default host: " | cut -d' ' -f3)

# Download the prebuilt rln library if it is available
if curl --silent --fail-with-body -L "https://github.com/vacp2p/zerokit/releases/download/v0.3.1/$host_triplet-rln.tar.gz" >> "$host_triplet-rln.tar.gz"
if curl --silent --fail-with-body -L "https://github.com/vacp2p/zerokit/releases/download/v0.3.2/$host_triplet-rln.tar.gz" >> "$host_triplet-rln.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe an unnecessary overkill, but what about getting the version from the submodule?

Something like

$ git submodule status vendor/zerokit | awk '{print $3}' | sed 's/[()]//g'
v0.3.1

So that there is only one source of truth for the version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will address in a follow up pr, thanks!

then
echo "Downloaded $host_triplet-rln.tar.gz"
tar -xzf "$host_triplet-rln.tar.gz"
Expand Down
2 changes: 1 addition & 1 deletion vendor/zerokit
Open in desktop
Submodule zerokit updated 11 files
+12 −12 Cargo.lock
+2 −0 rln-cli/src/commands.rs
+3 −0 rln-cli/src/main.rs
+1 −1 rln-cli/src/state.rs
+1 −5 rln-wasm/src/lib.rs
+2 −2 rln/Cargo.toml
+83 −34 rln/src/ffi.rs
+48 −4 rln/src/public.rs
+3 −0 rln/tests/ffi.rs
+2 −2 utils/Cargo.toml
+33 −11 utils/src/pm_tree/sled_adapter.rs