Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: postgres_driver.nim - rename table's name from "messages" to "message" #2110

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

Ivansete-status
Copy link
Collaborator

Description

Simple PR where we rename the Postgres table to a more idiomatic name for relational databases.

Issue

#1842

@Ivansete-status Ivansete-status self-assigned this Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This PR may contain changes to database schema of one of the drivers.

If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues.

Please make sure the label release-notes is added to make sure upgrade instructions properly highlight this change.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2110

Built from 548f6de

@Ivansete-status Ivansete-status marked this pull request as ready for review October 5, 2023 11:43
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you! :)

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine, thank you.

@Ivansete-status Ivansete-status merged commit 71cfbbc into master Oct 5, 2023
10 checks passed
@Ivansete-status Ivansete-status deleted the rename-message-table branch October 5, 2023 16:23
@jakubgs
Copy link
Contributor

jakubgs commented Oct 6, 2023

As far as I can tell this broke shards.test fleet:

ERR 2023-10-06 07:29:39.164+00:00 4/7 Mounting protocols failed              topics="wakunode main" tid=1 file=wakunode2.nim:85 error="failed to setup archive driver: error creating table: error in createMessageTable: rowsRes is err in exec: error in rows: ERROR:  relation \"messageindex\" already exists\n"

Endless restart loop.

@jakubgs
Copy link
Contributor

jakubgs commented Oct 6, 2023

I have built 12e8b122 - which is the preiovus commit - here:
https://ci.infra.status.im/job/nim-waku/job/deploy-shards-test/14/

And it works:

admin@store-01.ac-cn-hongkong-c.shards.test:~ % d
CONTAINER ID   NAMES            IMAGE                              CREATED              STATUS
e2f30b5bbb7f   nim-waku-store   wakuorg/nwaku:deploy-shards-test   About a minute ago   Up About a minute (healthy)

alrevuelta added a commit that referenced this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants