Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(autosharding): Functional Tests #2318

Merged
merged 3 commits into from
Jan 4, 2024
Merged

test(autosharding): Functional Tests #2318

merged 3 commits into from
Jan 4, 2024

Conversation

AlejandroCabeza
Copy link
Contributor

Description

Implement autosharding tests.

Changes

  • Autosharding tests
  • Helper Table==Array
  • Remove legacy tests¡

@AlejandroCabeza AlejandroCabeza self-assigned this Dec 25, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 25, 2023 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2318

Built from c49eedd

@AlejandroCabeza AlejandroCabeza changed the title Implement autosharding tests. test(autosharding): Functional Tests Dec 27, 2023
NagyZoltanPeter
NagyZoltanPeter requested changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the binary file added. Thanks for it.

tests/waku_core/topics/test_sharding Outdated Show resolved Hide resolved
@AlejandroCabeza AlejandroCabeza changed the title test(autosharding): Functional Tests test(autosharding): Functional Tests Dec 28, 2023
NagyZoltanPeter
NagyZoltanPeter approved these changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great, thank you!

SionoiS
SionoiS approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks.

tests/waku_core/topics/test_sharding.nim Show resolved Hide resolved
@AlejandroCabeza AlejandroCabeza merged commit 3bbe234 into master Jan 4, 2024
9 of 10 checks passed
@AlejandroCabeza AlejandroCabeza deleted the test-autosharding branch January 4, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NagyZoltanPeter NagyZoltanPeter NagyZoltanPeter approved these changes

@SionoiS SionoiS SionoiS approved these changes

Assignees

@AlejandroCabeza AlejandroCabeza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlejandroCabeza @SionoiS @NagyZoltanPeter