fix: adding rln validator as default #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 6d28045 |
gabrielmer
force-pushed
the
fix-adding-rln-validator-as-default
branch
from
0deb882 to
cc4c5b2
Compare
gabrielmer
changed the title
4 tasks
alrevuelta
reviewed
Jan 30, 2024
| @@ -130,6 +130,8 @@ type | |||
| # a map that stores whether the ordered validator has been inserted | |||
| # for a given PubsubTopic | |||
| validatorInserted: Table[PubsubTopic, bool] | |||
| # seq of validators that are called for every pubsub topic | |||
| wakuDefaultValidators: seq[WakuValidatorHandler] | |||
There was a problem hiding this comment.
not sure i understand this.
imho if rln is enabled, it should be enabled in all topics. same applies for all validators.
so not sure i understand the difference between validators and default validators. Having addValidator and addDefaultValidator creates some cognitive load for a use case that IMHO we don't have?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was noticed that RLN validator wasn't configured for dynamically subscribed pubsub topics.
Therefore, we decided to implement the same approach to validators as in go-waku: we're adding now support for default validators, which will be run for all pubsub topics. We're adding RLN validator to the default validators whenever RLN is enabled.
Changes
How to test
Simulated the scenario in which we send an invalid message on a dynamically added pubsub topics with and without this fix.
With this fix:
Without it:
Thanks @AlejandroCabeza for it!
Not adding the test in this PR as it is added in Alex's PR of the RLN test suite
Also, thanks @chaitanyaprem for helping from go-waku side to maintain consistency between both :)
Issue
closes #2365