Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: libwaku - simpler ctx mgmt. Param now receiving void* instead of void** #2398

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Ivansete-status
Copy link
Collaborator

@Ivansete-status Ivansete-status commented Feb 6, 2024

Description

This change is needed so that interoperability with other languages becomes simpler. Particularly, this simplification is needed from the Python point of view, where it is tricky to pass a void** as a parameter to an FFI function.

This change is needed to that the interoperability with other languages
become simpler. Particularly, this simplification is needed from the
Python point of view, where it is tricky to pass a void** as a parameter
to a FFI function.
@Ivansete-status Ivansete-status self-assigned this Feb 6, 2024
@Ivansete-status Ivansete-status marked this pull request as ready for review February 6, 2024 10:46
Copy link

github-actions bot commented Feb 6, 2024

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2398

Built from e72f200

Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better! Great!

Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@Ivansete-status Ivansete-status merged commit a81092e into master Feb 7, 2024
11 of 12 checks passed
@Ivansete-status Ivansete-status deleted the libwaku-simplify-ctx-management branch February 7, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants