Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: eventCallback per wakunode and userData #2418

Merged
merged 4 commits into from
Feb 13, 2024
Merged

feat: eventCallback per wakunode and userData #2418

merged 4 commits into from
Feb 13, 2024

Conversation

richard-ramos
Copy link
Member

Description

  1. Instead of using a global variable for the event callback, each wakunode instance will have their own event callback
  2. Uses some of the code changes from chore(cbindings): cbindings rust simple libwaku integration example #2089 to pass the userData to the callbacks

@richard-ramos richard-ramos changed the title Event cb per instance feat: eventCallback per wakunode and userData Feb 9, 2024
@waku-org waku-org deleted a comment from github-actions bot Feb 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 9, 2024 •
edited
Loading

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2418

Built from e291eb1

@richard-ramos richard-ramos marked this pull request as ready for review February 12, 2024 12:57
Ivansete-status
Ivansete-status approved these changes Feb 13, 2024
View reviewed changes
Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯

NagyZoltanPeter
NagyZoltanPeter approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@NagyZoltanPeter NagyZoltanPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for it, looks just good!!!

@richard-ramos richard-ramos changed the base branch from stddef.h to master February 13, 2024 14:21
@richard-ramos richard-ramos merged commit 707f3e8 into master Feb 13, 2024
8 checks passed
@richard-ramos richard-ramos deleted the eventCbPerInstance branch February 13, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansete-status Ivansete-status Ivansete-status approved these changes

@NagyZoltanPeter NagyZoltanPeter NagyZoltanPeter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richard-ramos @NagyZoltanPeter @Ivansete-status