chore(rln-relay-v2): added tests for static rln-relay-v2 #2484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from fb8bf41 |
rymnc
force-pushed
the
update-static-rln-v2-tests
branch
from
0db67f7 to
e445c37
Compare
rymnc
changed the title
rymnc
force-pushed
the
update-static-rln-v2-tests
branch
from
e445c37 to
5f31f48
Compare
Ivansete-status
approved these changes
Mar 4, 2024
| raise newException(ValueError, "Failed to remove member from the merkle tree") | ||
|
|
||
| if g.withdrawCb.isSome(): | ||
| await g.withdrawCb.get()(@[Membership(rateCommitment: rateCommitment, index: index)]) |
There was a problem hiding this comment.
Not super critical but shall we separate this line into two statements so that it is clear the item that withdrawCb is returning?
Co-authored-by: Ivan FB <128452529+Ivansete-status@users.noreply.github.com>
alrevuelta
approved these changes
Mar 4, 2024
| registrations[0].idCommitment == idCommitment | ||
| registrations[0].index == 10 | ||
| when defined(rln_v2): | ||
| require: |
There was a problem hiding this comment.
nitpick. registrations.len == 1 and registrations[0].index == 10 is the same in v1 and v2. extract it and remove the duplicate?
| withdrawals[0].index == 0 | ||
| when defined(rln_v2): | ||
| require: | ||
| withdrawals.len == 1 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows suit with the changes that were made in #2482
Updates the static group manager + tests for rln-v2, defaulting the UserMessageLimit to 20 for testing purposes.
Note
The rln-v2 test suite is not feature complete yet, i.e it has to be integrated in other test suites like
test_wakunode_rln_relay.nimandtest_waku_rln_relay.nim, those will be addressed in follow up PRsChanges
How to test
source env.shnim c --out:build/static_rln_test -r -d:chronicles_log_level=DEBUG -d:rln_v2:true -d:os=Darwin --verbosity:0 --hints:off -d:chronicles_log_level=TRACE -d:git_version="v0.24.0-rc.0-35-g50308e" -d:release --passL:librln_v0.4.1.a --passL:-lm tests/waku_rln_relay/test_rln_group_manager_static.nim