chore(rln-relay-v2): wakunode testing + improvements #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the image built from this PR at Built from 13227c2 |
rymnc
force-pushed
the
rln-relay-v2-more-tests
branch
from
32fdb4e to
f010cac
Compare
rymnc
changed the title
rymnc
force-pushed
the
rln-relay-v2-more-tests
branch
from
2daca1d to
89adeff
Compare
rymnc
commented
Mar 5, 2024
rymnc
force-pushed
the
rln-relay-v2-more-tests
branch
4 times, most recently
from
0988ea7 to
5d5c5ca
Compare
rymnc
added
the
E:RLN on mainnet
rymnc
force-pushed
the
rln-relay-v2-more-tests
branch
2 times, most recently
from
26fbdb9 to
7e1bfd8
Compare
rymnc
force-pushed
the
rln-relay-v2-more-tests
branch
from
7e1bfd8 to
c4604e7
Compare
Ivansete-status
approved these changes
Mar 11, 2024
.github/workflows/ci.yml
Outdated
| @@ -55,11 +55,12 @@ jobs: | |||
| if: ${{ needs.changes.outputs.v2 == 'true' || needs.changes.outputs.common == 'true' }} | |||
| strategy: | |||
| matrix: | |||
| rln_v2 : [true, false] | |||
There was a problem hiding this comment.
Interesting. Does that imply that the rln_v2 param is false for MacOS?
| @@ -58,7 +58,7 @@ const | |||
| # rln-v2: rate commitments are used for the Merkle tree construction, defaulting the UserMessageLimit to 20 | |||
| # the root is created locally, using createMembershipList proc from waku_rln_relay_utils module, and the result is hardcoded in here | |||
| when defined(rln_v2): | |||
| const StaticGroupMerkleRoot* = "0a15ba7c5753ee78e8126603113028a343c1a01ffcb389565c76626be158e964" | |||
| const StaticGroupMerkleRoot* = "2c149e48886b5ba3da2edf8db8d7a364ae7a25618489c04cf0c0380f7cdd4d6f" | |||
There was a problem hiding this comment.
Why this needs to be changed if the StaticGroupKeys seems not to be changed?
There was a problem hiding this comment.
This is because the leaves in the tree are derived from StaticGroupKeys in rln-v2, the leaf inserted is actually poseidon([identity_commitment, user_message_limit]) for the static group we default to 20 as the user_message_limit :)
alrevuelta
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows suit with the changes that were made in #2482, #2484
Updates the wakunode tests for rln-v2, defaulting the UserMessageLimit to 1 for testing purposes.
Note
This PR wraps up the modifications to all the tests related to rln-v2, and does not add additional test vectors. We should be ready to test this in waku-simulator.
Changes
How to test
RLN_V2=true make -j16 testIssue
closes #2345