chore: content_script_version_2: add simple protection and rm messages_backup if exists #2531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is aimed to add a simple protection. If the
messages_backup
exists, then delete it.Notice that this would only protect the users that are now running a version lower than
v0.26.0
, and update their nodes to a version >=v0.27.0
.EDITED: In further migrations, we might need to implement a rollback feature that should trigger if an error occurs within the migration, as suggested by @SionoiS some time ago.
How to test
Issue
closes waku-org/nwaku-compose#75