Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WakuStoreCodec string to beta4 #855

Merged
merged 6 commits into from
Feb 18, 2022
Merged

Update WakuStoreCodec string to beta4 #855

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a4265a4
Fix waku store version to beta4
s1fr0 Feb 17, 2022
527dab3
Updated changelog
s1fr0 Feb 17, 2022
59fb066
Fixed
s1fr0 Feb 17, 2022
2108789
Fixed
s1fr0 Feb 18, 2022
590ad2b
Better explanation
s1fr0 Feb 18, 2022
ba45701
Better explanation in changelog
s1fr0 Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ The full list of changes is below.

- A new type `Timestamp` for all timestamps is introduced (currently an alias for int64).
- All timestamps now have nanosecond resolution.
- `waku-store` version updated to `2.0.0-beta3`
Copy link
Contributor

@staheri14 staheri14 Feb 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `waku-store` version updated to `2.0.0-beta3`
- `waku-store` protocol identifier is updated to `/vac/waku/store/2.0.0-beta4`


### Fixes

Expand Down
2 changes: 1 addition & 1 deletion waku/v2/node/wakunode2.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ proc protocolMatcher(codec: string): Matcher =
proc match(proto: string): bool {.gcsafe.} =
## Matches a proto with any postfix to the provided codec.
## E.g. if the codec is `/vac/waku/filter/2.0.0` it matches the protos:
## `/vac/waku/filter/2.0.0`, `/vac/waku/filter/2.0.0-beta3`, `/vac/waku/filter/2.0.0-actualnonsense`
## `/vac/waku/filter/2.0.0`, `/vac/waku/filter/2.0.0-beta4`, `/vac/waku/filter/2.0.0-actualnonsense`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filter protocol is not updated

return proto.startsWith(codec)

return match
Expand Down
2 changes: 1 addition & 1 deletion waku/v2/protocol/waku_store/waku_store.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ logScope:
topics = "wakustore"

const
WakuStoreCodec* = "/vac/waku/store/2.0.0-beta3"
WakuStoreCodec* = "/vac/waku/store/2.0.0-beta4"
DefaultStoreCapacity* = 50000 # Default maximum of 50k messages stored

# Error types (metric label values)
Expand Down