Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add meta field to WakuMessage, and ephemeral to RelayWakuMessage #2

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix: add meta field to WakuMessage, and ephemeral to RelayWakuMessage #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions api-spec/schemas/apitypes.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ WakuMessage:
format: int64
ephemeral:
type: boolean
meta:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about rateLimitProof? According to https://rfc.vac.dev/spec/17/#wakumessage it can also be part of the message.
Also I saw that RPC protocol will return it, but REST does not

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I'd like to return all the fields that are part of the wakumessage protobuffer, instead of just an specific subset

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's okay to do that?
cc: @NagyZoltanPeter what do you think if we return all fields available in the protobuffer?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be the quickest reply ever. Yes I do think we should mimic protobuf structures over REST API.

type: string
format: byte
required:
- payload
- contentTopic
Expand Down Expand Up @@ -146,6 +149,11 @@ RelayWakuMessage:
type: number
timestamp:
type: number
ephemeral:
type: boolean
meta:
type: string
format: byte
required:
- payload

Expand Down