Skip to content

Commit 3a65020

Browse files
AbdeMohlbiwalley892
authored andcommitted
Replace deprecated withOpacity in focus_scope.0.dart‎ example (flutter#177542)
Original PR that was intended to fix all examples: - flutter#177205 It was later split into smaller PRs due to a major misunderstanding and test failures caused by color values not matching exactly. Similar PRs: - flutter#177374 - flutter#177490 - flutter#177540 - flutter#177541 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent e5706c3 commit 3a65020

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

examples/api/lib/widgets/focus_scope/focus_scope.0.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ class _FocusScopeExampleState extends State<FocusScopeExample> {
135135
child: Pane(
136136
icon: const Icon(Icons.menu),
137137
focusNode: foregroundNode,
138-
// TRY THIS: Try changing this to Colors.green.withOpacity(0.8) to see for
138+
// TRY THIS: Try changing this to Colors.green.withValues(alpha: 0.8) to see for
139139
// yourself that the hidden components do/don't get focus.
140140
backgroundColor: Colors.green,
141141
onPressed: backdropIsVisible ? null : () => setState(() => backdropIsVisible = true),

0 commit comments

Comments
 (0)