Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: code coverage info #1002

Closed
wants to merge 4 commits into from
Closed

cli: code coverage info #1002

wants to merge 4 commits into from

Conversation

brig
Copy link
Contributor

@brig brig commented Oct 22, 2024 •
edited
Loading

simple code coverage with Concord cli:

concord-cli run . --with-code-coverage

logs:

Starting...
13:39:12.073 [main] Hello, Concord!
===
Generating code coverage info...
Coverage info file: /Users/brig/prj/github/concord/examples/hello_world/target/coverage.info
To generate HTML report with lcov use:
	cd /Users/brig/prj/github/concord/examples/hello_world/target && genhtml coverage.info --output-directory out
===
...done!
Screenshot 2024-10-22 at 13 41 24

@brig brig requested a review from a team October 22, 2024 17:41
@brig
Copy link
Contributor Author

brig commented Oct 22, 2024 

flows:
  default:
    - log: "Hello, ${name}!"

  unusedFlow:
    - log: "Why..."

configuration:
  arguments:
    name: "Concord"
Screenshot 2024-10-22 at 13 44 05

@brig brig mentioned this pull request Oct 22, 2024
Merged
ibodrov
ibodrov approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@ibodrov ibodrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make var usage consistent for new files?

...me/v2/runner/src/main/java/com/walmartlabs/concord/runtime/v2/runner/ProcessEventWriter.java

import java.util.List;

public interface ProcessEventWriter {
Copy link
Collaborator

@ibodrov ibodrov Oct 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, EventReportingService is back but it is better now! 😆

@brig
Copy link
Contributor Author

brig commented Oct 22, 2024

I was thinking that maybe this should be a runtime plugin... I'll think about it a bit more, don't merge this PR pls :)

@brig brig added the wip Work in progress, do not merge label Oct 22, 2024
@brig
Copy link
Contributor Author

brig commented Dec 1, 2024

I will implement it in concord-plugins

@brig brig closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbroadaway benbroadaway benbroadaway approved these changes

@ibodrov ibodrov ibodrov approved these changes

Assignees
No one assigned
Labels
wip Work in progress, do not merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brig @ibodrov @benbroadaway