wasmer-c-api-changes: making wasmer_byte_array fields public
#589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaronWittenstein
added a commit
to spacemeshos/wasmer
that referenced
this pull request
Jul 29, 2019
… making `wasmer_byte_array` fields `public` wasmerio#589")
…t we can do `assert_eq!`)
YaronWittenstein
force-pushed
the
wasmer-c-api-changes
branch
from
0002b1f to
8408260
Compare
bjfish
approved these changes
Aug 1, 2019
|
This looks good to me. |
bors bot
added a commit
that referenced
this pull request
Aug 1, 2019
589: wasmer-c-api-changes: making `wasmer_byte_array` fields `public` r=bjfish a=YaronWittenstein I've added this PR since I've tests that need access to `wasmer_byte_array` field. Here is an example: https://github.com/spacemeshos/svm/blob/52f04b52cc9a5227030f3dd3499e04c6cbe143d9/crates/svm-wasmer-c-api/tests/c_api.rs#L96 ```rust unsafe fn cast_wasmer_byte_array_to_string(wasmer_bytes: &wasmer_byte_array) -> String { let slice: &[u8] = std::slice::from_raw_parts(wasmer_bytes.bytes, wasmer_bytes.bytes_len as usize); if let Ok(s) = std::str::from_utf8(slice) { s.to_string() } else { panic!("error converting `wasmer_byte_array` to string") } } ``` @syrusakbary @bjfish @Hywan Co-authored-by: Yaron Wittenstein <yaron.wittenstein@gmail.com> Co-authored-by: Brandon Fish <bjfish@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added this PR since I've tests that need access to
wasmer_byte_arrayfield.Here is an example:
https://github.com/spacemeshos/svm/blob/52f04b52cc9a5227030f3dd3499e04c6cbe143d9/crates/svm-wasmer-c-api/tests/c_api.rs#L96
@syrusakbary @bjfish @Hywan