Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate initializers before writing to memory #659

Merged
merged 3 commits into from
Aug 11, 2019
Merged

Validate initializers before writing to memory #659

merged 3 commits into from
Aug 11, 2019

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Aug 10, 2019

Fixes linking.wast:342

@bjfish
Copy link
Contributor Author

bjfish commented Aug 10, 2019

bors try

bors bot added a commit that referenced this pull request Aug 10, 2019
@bors
Try #659:
75d1aa4
@bjfish
Copy link
Contributor Author

bjfish commented Aug 10, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 10, 2019
@bors @bjfish
Merge #659
70b7e6f 
659: Validate initializers before writing to memory r=bjfish a=bjfish

Fixes `linking.wast:342`

Co-authored-by: Brandon Fish <brandon.j.fish@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 10, 2019

try

Build succeeded

@bors
Copy link
Contributor

bors bot commented Aug 10, 2019

Build failed

@bjfish
Copy link
Contributor Author

bjfish commented Aug 11, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 11, 2019
@bors @bjfish
Merge #659
6ac3ac1 
659: Validate initializers before writing to memory r=bjfish a=bjfish

Fixes `linking.wast:342`

Co-authored-by: Brandon Fish <brandon.j.fish@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 11, 2019

Build succeeded

@bors bors bot merged commit 38a8a0e into master Aug 11, 2019
@bors bors bot deleted the feature/validate-initializer-before-mem-write branch August 11, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@Hywan Hywan Awaiting requested review from Hywan

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

@nlewycky nlewycky Awaiting requested review from nlewycky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjfish @syrusakbary