Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix singlepass error when no function code present #680

Merged
merged 4 commits into from
Aug 19, 2019
Merged

Fix singlepass error when no function code present #680

merged 4 commits into from
Aug 19, 2019

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Aug 15, 2019

No description provided.

@bjfish bjfish requested a review from losfair August 15, 2019 16:26
bjfish
bjfish commented Aug 15, 2019
View reviewed changes
lib/singlepass-backend/src/codegen_x64.rs
return Err(CodegenError {
message: "no function",
});
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@losfair the addition below is repeated in next_function, maybe it could be consolidated in the future.

@losfair
Copy link
Contributor

losfair commented Aug 16, 2019

bors try

bors bot added a commit that referenced this pull request Aug 16, 2019
@bors
Try #680:
8994fef
@bors
Copy link
Contributor

bors bot commented Aug 16, 2019

try

Build succeeded

@bjfish
Copy link
Contributor Author

bjfish commented Aug 19, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 19, 2019
@bors @bjfish
Merge #680
6b2cd7e 
680: Fix singlepass error when no function code present r=bjfish a=bjfish



Co-authored-by: Brandon Fish <brandon.j.fish@gmail.com>
Co-authored-by: Brandon Fish <bjfish@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Aug 19, 2019

Build succeeded

@bors bors bot merged commit 38b1e3d into master Aug 19, 2019
@bors bors bot deleted the feature/fix-singlepass-panic-no-functions branch August 19, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losfair losfair losfair approved these changes

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

@nlewycky nlewycky Awaiting requested review from nlewycky

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjfish @losfair