Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on AArch64 Linux. #703

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Fix compilation on AArch64 Linux. #703

merged 1 commit into from
Aug 21, 2019

Conversation

losfair
Copy link
Contributor

@losfair losfair commented Aug 20, 2019

This only fixes compilation. Cranelift still reports many not yet implemented on AArch64.

@losfair losfair force-pushed the fix/aarch64-compilation branch from c40eba3 to 3f0dae3 Compare August 20, 2019 23:37
@@ -168,13 +168,13 @@ pub fn ___syscall38(ctx: &mut Ctx, _which: c_int, mut varargs: VarArgs) -> i32 {
debug!("emscripten::___syscall38 (rename)");
let old_path = varargs.get_str(ctx);
let new_path = varargs.get_str(ctx);
let real_old_path_owned = get_cstr_path(ctx, old_path);
let real_old_path_owned = get_cstr_path(ctx, old_path as *const _);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why this is an architecture specific issue 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust libstd for ARM (both 32 and 64) uses u8 instead of i8 in many places. I don't understand why though.

@losfair
Copy link
Contributor Author

losfair commented Aug 21, 2019

bors r+

bors bot added a commit that referenced this pull request Aug 21, 2019
703: Fix compilation on AArch64 Linux. r=losfair a=losfair

This only fixes compilation. Cranelift still reports many `not yet implemented` on AArch64.

Co-authored-by: losfair <zhy20000919@hotmail.com>
@bors bors bot merged commit 3f0dae3 into master Aug 21, 2019
@bors bors bot deleted the fix/aarch64-compilation branch August 21, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants