Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialization for WASI state #726

Merged
merged 11 commits into from
Sep 4, 2019
Merged

Add serialization for WASI state #726

merged 11 commits into from
Sep 4, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented Aug 27, 2019 •
edited
Loading

part of #700

Due to the trait objects from #583 , we can't use serde derive for this or use serde traits directly, we have to do some custom serialization (edit: luckily there's a crate for this: typetag)

@MarkMcCaskey MarkMcCaskey added the 📦 lib-wasi About wasmer-wasi label Aug 27, 2019
@MarkMcCaskey MarkMcCaskey changed the title Add serialization for WASI state - wip Add serialization for WASI state Aug 28, 2019
@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 28, 2019
@bors
Try #726:
4bf6bf3
@bors
Copy link
Contributor

bors bot commented Aug 28, 2019

try

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 28, 2019
@bors
Try #726:
5764237
@bors
Copy link
Contributor

bors bot commented Aug 28, 2019

try

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 28, 2019
@bors
Try #726:
8cbeba9
@bors
Copy link
Contributor

bors bot commented Aug 28, 2019

try

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 28, 2019
@bors
Try #726:
7c84647
@bors
Copy link
Contributor

bors bot commented Aug 28, 2019

try

Build failed

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 28, 2019
@bors
Try #726:
5fe8f7b
@MarkMcCaskey MarkMcCaskey requested a review from losfair August 28, 2019 22:20
@bors
Copy link
Contributor

bors bot commented Aug 28, 2019

try

Build succeeded

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Aug 29, 2019
@bors
Try #726:
03a7808
@bors
Copy link
Contributor

bors bot commented Aug 29, 2019

try

Build succeeded

@syrusakbary
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Sep 1, 2019
@bors
Try #726:
cf83354
@bors
Copy link
Contributor

bors bot commented Sep 1, 2019

try

Build failed

  • wasmerio.wasmer

@syrusakbary
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Sep 1, 2019
@bors
Try #726:
ffa7fda
@bors
Copy link
Contributor

bors bot commented Sep 1, 2019

try

Build failed

  • wasmerio.wasmer

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 4, 2019
@bors
Try #726:
ba944d4
nlewycky
nlewycky approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@nlewycky nlewycky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there are unread bytes waiting on stdin, we drop them on the floor.

@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Sep 4, 2019
@bors @MarkMcCaskey @syrusakbary
Merge #726
1506655 
726: Add serialization for WASI state  r=MarkMcCaskey a=MarkMcCaskey

part of #700 

Due to the trait objects from #583 , we can't use `serde` derive for this or use serde traits directly, we have to do some custom serialization (edit: luckily there's a crate for this: `typetag`)

Co-authored-by: Mark McCaskey <mark@wasmer.io>
Co-authored-by: Mark McCaskey <markmccaskey@users.noreply.github.com>
Co-authored-by: Syrus Akbary <me@syrusakbary.com>
@bors
Copy link
Contributor

bors bot commented Sep 4, 2019

try

Build succeeded

  • wasmerio.wasmer

@MarkMcCaskey MarkMcCaskey mentioned this pull request Sep 4, 2019
Closed
@bors
Copy link
Contributor

bors bot commented Sep 4, 2019

Build succeeded

  • wasmerio.wasmer

@bors bors bot merged commit 7a9afbf into master Sep 4, 2019
@bors bors bot deleted the feature/serialization-of-wasi-state branch September 4, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewycky nlewycky nlewycky approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

@losfair losfair Awaiting requested review from losfair

Assignees
No one assigned
Labels
📦 lib-wasi About wasmer-wasi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkMcCaskey @syrusakbary @nlewycky