Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add early exit example #1657

Merged
merged 5 commits into from
Sep 30, 2020
Merged

Add early exit example #1657

merged 5 commits into from
Sep 30, 2020

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented Sep 28, 2020 •
edited
Loading

Resolves #1597
Resolves #1426

This PR currently contains the example in both C and Rust

Review

  • Add a short description of the the change to the CHANGELOG.md file

syrusakbary
syrusakbary approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

@MarkMcCaskey MarkMcCaskey requested a review from Hywan as a code owner September 29, 2020 17:56
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2020 •
edited
Loading

Codecov Report

Merging #1657 into master will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1657   +/-   ##
=======================================
  Coverage   31.72%   31.72%           
=======================================
  Files         185      185           
  Lines       26997    27001    +4     
=======================================
+ Hits         8565     8567    +2     
- Misses      18432    18434    +2
Impacted Files Coverage Δ
lib/c-api/src/wasm_c_api/mod.rs 0.00% <0.00%> (ø)
lib/engine/src/trap/frame_info.rs 39.39% <ø> (ø)
lib/compiler-cranelift/src/config.rs 62.50% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62f6b54...ffe1c5a. Read the comment docs.

@MarkMcCaskey
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Sep 29, 2020
@bors
Try #1657:
b084c3c
nlewycky
nlewycky reviewed Sep 29, 2020
View reviewed changes
examples/early_exit.rs Outdated Show resolved Hide resolved
examples/early_exit.rs Outdated Show resolved Hide resolved
examples/early_exit.rs Outdated Show resolved Hide resolved
lib/c-api/src/wasm_c_api/mod.rs Outdated Show resolved Hide resolved
lib/c-api/src/wasm_c_api/mod.rs Outdated Show resolved Hide resolved
lib/c-api/tests/assets/call_trap.wat Outdated Show resolved Hide resolved
lib/c-api/tests/wasm-c-api-early-exit.c Show resolved Hide resolved
lib/c-api/tests/wasm-c-api-early-exit.c Outdated Show resolved Hide resolved
lib/c-api/tests/wasm-c-api-early-exit.c Show resolved Hide resolved
lib/c-api/tests/wasm-c-api-early-exit.c Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors bot commented Sep 29, 2020

try

Build succeeded:

@MarkMcCaskey
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 30, 2020

Build succeeded:

@bors bors bot merged commit d924639 into master Sep 30, 2020
@bors bors bot deleted the example/early-exit branch September 30, 2020 00:23
Hywan added a commit to Hywan/wasmer that referenced this pull request Oct 1, 2020
@Hywan
fix(c-api) Cherry-pick manually from wasmerio#1657.
ecb79e2
Hywan added a commit to Hywan/wasmer that referenced this pull request Oct 1, 2020
@Hywan
fix(c-api) Cherry-pick manually from wasmerio#1657.
9062108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewycky nlewycky nlewycky left review comments

@syrusakbary syrusakbary syrusakbary approved these changes

@Hywan Hywan Awaiting requested review from Hywan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Example: How to terminate a program via an Import How to Trigger a trap from the context of an import
4 participants
@MarkMcCaskey @codecov-commenter @syrusakbary @nlewycky