Prevent panic when min > static bound and max is less than it #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkMcCaskey
force-pushed
the
fix/panic-in-memory-api
branch
2 times, most recently
from
9bc0977 to
4a00ee2
Compare
MarkMcCaskey
force-pushed
the
fix/panic-in-memory-api
branch
from
4a00ee2 to
e3ec9f3
Compare
syrusakbary
approved these changes
Oct 15, 2020
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should be safe because we check that min <= max when actually making the memory, so this assert can never fire and produce a
MemoryStylethat would let us create a memory.This PR also tests a lot more edge cases of memory creation in the C API.
Resolves the issue brought up here #1631 (comment)
Review