For store instructions, always load first. #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instance if it is partways in valid memory and partways into the guard page. Use a load instruction before the store to ensure that all the memory is addressable. The loaded value is discarded. NB. We don't apply this to atomics. It's not clear whether atomic stores can be half-committed. Fixes align.wast and memory_trap.wast on aarch64.
syrusakbary
reviewed
Oct 17, 2020
They aren't disabled. They're just failing. The cranelift ones are disabled, but this doesn't fix those. For LLVM we simply never turned on testing on arm yet. |
syrusakbary
approved these changes
Oct 17, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Oct 17, 2020
1731: For store instructions, always load first. r=nlewycky a=nlewycky Sometimes the store may be partially-successful before trapping, for instance if it is partway in valid memory and partway into the guard page. Use a load instruction before the store to ensure that all the memory is addressable. The loaded value is discarded. NB. We don't apply this to atomics. It's not clear whether atomic stores can be half-committed. Fixes align.wast and memory_trap.wast on aarch64. 1732: Make wasi tests use the engine we're testing instead of always engine-jit. r=nlewycky a=nlewycky Co-authored-by: Nick Lewycky <nick@wasmer.io>
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the store may be partially-successful before trapping, for instance if it is partway in valid memory and partway into the guard page.
Use a load instruction before the store to ensure that all the memory is addressable. The loaded value is discarded.
NB. We don't apply this to atomics. It's not clear whether atomic stores can be half-committed.
Fixes align.wast and memory_trap.wast on aarch64.