fix make debug-release #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
|
bors try |
tryAlready running a review |
|
bors try |
tryBuild failed |
|
bors try |
syrusakbary
approved these changes
Mar 20, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 20, 2019
284: fix make debug-release r=MarkMcCaskey a=MarkMcCaskey My guess without looking in to the history is that: - the unsafe block was around the `debug!` call - when debug was off, it was giving a warning because the unsafe block was empty - the unsafe was removed to stop the warning - it wasn't tested with the debug flag This PR also - cleans up the Makefile - adds debug-release to CI Co-authored-by: Mark McCaskey <mark@wasmer.io>
surban
pushed a commit
to rust-wasi-web/wwrr
that referenced
this pull request
Nov 9, 2024
surban
pushed a commit
to rust-wasi-web/wwrr
that referenced
this pull request
Nov 9, 2024
Return the raw instance when instantiating. Fix wasmerio#284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My guess without looking in to the history is that:
debug!callThis PR also