Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal runtime ↔️ backend abstraction refactor. #348

Merged
merged 15 commits into from
Apr 17, 2019

Conversation

lachlansneff
Copy link
Contributor

This replaces the ProtectedCaller and FuncResolver traits with a combined RunnableModule trait. I'd like to get this merged, since it's standalone, but there are follow-up PRs I'd like to make that will further change the abstraction

@lachlansneff
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Apr 12, 2019
@bors
Copy link
Contributor

bors bot commented Apr 12, 2019

@lachlansneff lachlansneff requested review from losfair and bjfish April 12, 2019 17:57
@syrusakbary
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Apr 12, 2019
@bors
Copy link
Contributor

bors bot commented Apr 12, 2019

try

Build failed

@lachlansneff
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Apr 17, 2019
@lachlansneff lachlansneff requested a review from Hywan April 17, 2019 21:18
@bors
Copy link
Contributor

bors bot commented Apr 17, 2019

@lachlansneff
Copy link
Contributor Author

thank you @bjfish

bors r+

bors bot added a commit that referenced this pull request Apr 17, 2019
348: Internal runtime ↔️ backend abstraction refactor. r=lachlansneff a=lachlansneff

This replaces the `ProtectedCaller` and `FuncResolver` traits with a combined `RunnableModule` trait. I'd like to get this merged, since it's standalone, but there are follow-up PRs I'd like to make that will further change the abstraction

Co-authored-by: Lachlan Sneff <lachlan.sneff@gmail.com>
Co-authored-by: Syrus Akbary <me@syrusakbary.com>
@bors
Copy link
Contributor

bors bot commented Apr 17, 2019

@bors bors bot merged commit 088263a into master Apr 17, 2019
@bors bors bot deleted the feature/remove-call-protected branch April 17, 2019 22:00
surban pushed a commit to rust-wasi-web/wwrr that referenced this pull request Nov 9, 2024
…s--main--components--wasmer-sdk

chore(main): release wasmer-sdk 0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants