Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single-pass fixes and optimizations. #360

Merged
merged 6 commits into from
Apr 18, 2019
Merged

Single-pass fixes and optimizations. #360

merged 6 commits into from
Apr 18, 2019

Conversation

losfair
Copy link
Contributor

@losfair losfair commented Apr 16, 2019

No description provided.

@lachlansneff
Copy link
Contributor

I'd like to get this merged as soon as possible so we can start this refactor:

                                                                                         +-------------+  +------------+
                                                                                 +------>+ Single Pass +->+Machine Code|
                                                                                 |       +-------------+  +------------+
+----------------+                                                               |
|                |     +----------+      +-----------+     +---------------+     |
|                |     |          |      |           |     |               |     |       +-----------+    +------------+
|      Wasm      +---->+  Parser  +----->+ IR/Events +---->+ IR Transforms +------------>+ Cranelift +--->+Machine Code|
|                |     |          |      |           |     |               |     |       +-----------+    +------------+
|                |     +----------+      +-----------+     +---------------+     |
+----------------+                                                               |
                                                                                 |         +------+       +------------+
                                                                                 +-------->+ LLVM +------>+Machine Code|
                                                                                           +------+       +------------+

@lachlansneff
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Apr 17, 2019
@bors
Try #360:
af219c6
@bors
Copy link
Contributor

bors bot commented Apr 17, 2019

try

Build failed

@lachlansneff
Copy link
Contributor

bors try

@bors
Copy link
Contributor

bors bot commented Apr 17, 2019

try

Merge conflict

@lachlansneff
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Apr 17, 2019
@bors
Try #360:
aaf2c5c
@bors
Copy link
Contributor

bors bot commented Apr 17, 2019

try

Build succeeded

lachlansneff
lachlansneff approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@lachlansneff lachlansneff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. 👍

@losfair losfair marked this pull request as ready for review April 18, 2019 03:49
@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Apr 18, 2019
@bors @losfair @lachlansneff
Merge #360
ccad887 
360: Single-pass fixes and optimizations. r=syrusakbary a=losfair



Co-authored-by: losfair <zhy20000919@hotmail.com>
Co-authored-by: Lachlan Sneff <lachlan.sneff@gmail.com>
@bors
Copy link
Contributor

bors bot commented Apr 18, 2019

Build succeeded

@bors bors bot merged commit 016535c into master Apr 18, 2019
@bors bors bot deleted the feature/singlepass-opt branch April 18, 2019 15:16
surban pushed a commit to rust-wasi-web/wwrr that referenced this pull request Nov 9, 2024
Merge pull request wasmerio#360 from wasmerio/stdoutBytes
739336b 
Improve stdout/stderr output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lachlansneff lachlansneff lachlansneff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@losfair @lachlansneff @syrusakbary