Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix write to flush buffer; fix warnings #368

Merged
merged 2 commits into from
Apr 20, 2019
Merged

fix write to flush buffer; fix warnings #368

merged 2 commits into from
Apr 20, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey commented Apr 19, 2019 •
edited
Loading

resolves #363

@MarkMcCaskey MarkMcCaskey added the 📦 lib-wasi About wasmer-wasi label Apr 19, 2019
@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Apr 20, 2019
@bors
Merge #368
363b46e 
368: fix write to flush buffer; fix warnings r=MarkMcCaskey a=MarkMcCaskey

resolves #363 

Co-authored-by: Mark McCaskey <mark@wasmer.io>
@bors
Copy link
Contributor

bors bot commented Apr 20, 2019

Build succeeded

@bors bors bot merged commit 9256f6e into master Apr 20, 2019
@bors bors bot deleted the fix/buffered-output branch April 20, 2019 00:33
surban pushed a commit to rust-wasi-web/wwrr that referenced this pull request Nov 9, 2024
Merge pull request wasmerio#368 from wasmerio/michael/sdk-38-providin…
7ea45ca 
…g-stdin-up-front-seems-to-always-read-the-same-bytes

Pick up wasmerio#4355 to fix stdin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmclark xmclark xmclark approved these changes

@lachlansneff lachlansneff Awaiting requested review from lachlansneff

Assignees
No one assigned
Labels
📦 lib-wasi About wasmer-wasi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WASI fd_write to stdout is buffered and should be unbuffered
2 participants
@MarkMcCaskey @xmclark