Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more Debug impl for WASI types #371

Merged
merged 2 commits into from
Apr 20, 2019
Merged

Add more Debug impl for WASI types #371

merged 2 commits into from
Apr 20, 2019

Conversation

bjfish
Copy link
Contributor

@bjfish bjfish commented Apr 20, 2019

No description provided.

@bjfish bjfish requested a review from MarkMcCaskey April 20, 2019 19:23
@bjfish
Copy link
Contributor Author

bjfish commented Apr 20, 2019

bors try

bors bot added a commit that referenced this pull request Apr 20, 2019
@bors
Try #371:
4b74e14
@bors
Copy link
Contributor

bors bot commented Apr 20, 2019

try

Build succeeded

syrusakbary
syrusakbary approved these changes Apr 20, 2019
View reviewed changes
Copy link
Member

@syrusakbary syrusakbary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjfish
Copy link
Contributor Author

bjfish commented Apr 20, 2019

bors r+

bors bot added a commit that referenced this pull request Apr 20, 2019
@bors @bjfish
Merge #371
6478500 
371: Add more Debug impl for WASI types r=bjfish a=bjfish



Co-authored-by: Brandon Fish <brandon.j.fish@gmail.com>
Co-authored-by: Brandon Fish <bjfish@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Apr 20, 2019

Build succeeded

@bors bors bot merged commit 2516a1e into master Apr 20, 2019
@bors bors bot deleted the feature/wasi-more-debug branch April 20, 2019 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@MarkMcCaskey MarkMcCaskey Awaiting requested review from MarkMcCaskey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjfish @syrusakbary