Add MiddlewareChain and StreamingCompiler to runtime #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
syrusakbary
approved these changes
Jun 10, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 10, 2019
490: Add MiddlewareChain and StreamingCompiler to runtime r=syrusakbary a=bjfish
It would be nice to add `MiddlewareChain` and `StreamingCompiler` to runtime to be able to use these without having to include the `runtime-core` as a dependency. For example:
```rust
use wasmer_runtime::{MiddlewareChain, StreamingCompiler};
use wasmer_singlepass_backend::ModuleCodeGenerator as SinglePassMCG;
use wasmer_middleware_common::metering::Metering;
let limit = 1_000_000;
let c: StreamingCompiler<SinglePassMCG, _, _, _, _> = StreamingCompiler::new(move || {
let mut chain = MiddlewareChain::new();
chain.push(Metering::new(limit));
chain
});
wasmer_runtime::compile_with(&prepared_code, &c)
.map_err(|e| Error::Wasmer(format!("{}", e)))
chain
});
wasmer_runtime::compile_with(&prepared_code, &c)
.map_err(|e| Error::Wasmer(format!("{}", e)))
```
Co-authored-by: Brandon Fish <brandon.j.fish@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to add
MiddlewareChainandStreamingCompilerto runtime to be able to use these without having to include theruntime-coreas a dependency. For example: