Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix 857] panic when target module don't have exported _start function #858

Merged
merged 7 commits into from
Dec 11, 2019
Merged

[fix 857] panic when target module don't have exported _start function #858

merged 7 commits into from
Dec 11, 2019

Conversation

pventuzelo
Copy link
Contributor

@pventuzelo pventuzelo commented Oct 2, 2019 •
edited
Loading

Description

Fix #857

  • replace expect by map_err for loader
  • replace expect by map_err in other part of wasmer.rs

Review

  • Add a short description of the the change to the CHANGELOG.md file

MarkMcCaskey
MarkMcCaskey approved these changes Oct 2, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@pventuzelo pventuzelo changed the title Fix 857 - panic when target module don't have exported _start function [fix 857] - panic when target module don't have exported _start function Oct 3, 2019
@pventuzelo pventuzelo changed the title [fix 857] - panic when target module don't have exported _start function [fix 857] panic when target module don't have exported _start function Oct 3, 2019
MarkMcCaskey
MarkMcCaskey approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@MarkMcCaskey MarkMcCaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@syrusakbary
Copy link
Member

Somehow we didn't merge this. @pventuzelo can you update the PR with the latest master?

@pventuzelo
Copy link
Contributor Author

@syrusakbary Done ;)

@syrusakbary
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Dec 11, 2019
@bors @pventuzelo
Merge #858
18318c2 
858: [fix 857] panic when target module don't have exported _start function r=syrusakbary a=pventuzelo

# Description

Fix #857 
* replace `expect` by `map_err` for `loader`
* replace `expect` by `map_err` in other part of `wasmer.rs`

# Review

- [x] Add a short description of the the change to the CHANGELOG.md file


Co-authored-by: Patrick Ventuzelo <ventuzelo.patrick@gmail.com>
Co-authored-by: Patrick Ventuzelo <9038181+pventuzelo@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 11, 2019

Build succeeded

@bors bors bot merged commit 3836b54 into wasmerio:master Dec 11, 2019
@pventuzelo pventuzelo deleted the ventuzelo/fix-857-panic-loader-parameter branch December 11, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkMcCaskey MarkMcCaskey MarkMcCaskey approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasmer binary] panic when target module don't have exported _start function
3 participants
@pventuzelo @syrusakbary @MarkMcCaskey