Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos #884

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fix: typos #884

merged 1 commit into from
Jan 12, 2024

Conversation

Thabokani
Copy link
Contributor

fix some typos

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
br_table
1.49ms 1.48ms ⚪ -0.59% 1.35ms 1.37ms ⚪ 1.02% 🟢 -8%
execute/
call/host/1
52.18µs 50.67µs 🟢 -2.89% 63.34µs 63.44µs ⚪ 0.16% 🟢 25%
execute/
call/rec
171.64µs 172.30µs ⚪ 0.38% 335.46µs 334.75µs ⚪ -0.21% 🟡 94%
execute/
count_until
5.35ms 5.34ms ⚪ -0.25% 7.51ms 7.50ms ⚪ -0.06% 🟢 41%
execute/
divrem
6.33ms 6.32ms ⚪ -0.06% 7.06ms 7.05ms ⚪ -0.03% 🟢 12%
execute/
factorial/iter
266.68µs 266.77µs ⚪ 0.03% 300.60µs 299.52µs ⚪ -0.36% 🟢 12%
execute/
factorial/rec
668.71µs 686.32µs 🔴 2.63% 1.26ms 1.27ms ⚪ 0.73% 🟡 85%
execute/
fibonacci/iter
1.33ms 1.34ms ⚪ 0.23% 1.24ms 1.24ms ⚪ -0.08% 🟢 -7%
execute/
fibonacci/rec
5.91ms 5.88ms ⚪ -0.42% 11.96ms 12.41ms 🔴 3.74% 🔴 111%
execute/
fibonacci/tail
1.25ms 1.28ms 🔴 1.90% 4.39ms 4.41ms ⚪ 0.45% 🔴 245%
execute/
fuse
7.11ms 7.11ms ⚪ 0.00% 11.80ms 11.81ms ⚪ 0.10% 🟡 66%
execute/
global/bump
1.32ms 1.32ms ⚪ -0.44% 1.79ms 1.79ms ⚪ 0.05% 🟢 36%
execute/
global/get_const
501.28µs 480.35µs 🟢 -4.18% 746.99µs 747.20µs ⚪ 0.03% 🟡 56%
execute/
is_even/rec
1.10ms 1.10ms ⚪ 0.17% 2.07ms 2.07ms ⚪ -0.37% 🟡 88%
execute/
memory/fill_bytes
1.11ms 1.11ms ⚪ -0.17% 1.31ms 1.30ms ⚪ -0.25% 🟢 17%
execute/
memory/sum_bytes
1.05ms 1.05ms ⚪ -0.19% 1.33ms 1.34ms ⚪ 0.20% 🟢 27%
execute/
memory/vec_add
2.96ms 2.95ms ⚪ -0.49% 3.58ms 3.57ms ⚪ -0.31% 🟢 21%
execute/
recursive_scan
188.27µs 187.75µs ⚪ -0.28% 352.57µs 353.11µs ⚪ 0.15% 🟡 88%
execute/
recursive_trap
15.88µs 15.73µs ⚪ -0.93% 32.11µs 31.95µs ⚪ -0.50% 🔴 103%
execute/
regex_redux
581.93µs 581.05µs ⚪ -0.15% 1.13ms 1.13ms ⚪ 0.31% 🟡 95%
execute/
rev_complement
444.21µs 443.63µs ⚪ -0.13% 690.96µs 679.85µs 🟢 -1.61% 🟡 53%
execute/
tiny_keccak
351.54µs 351.29µs ⚪ -0.07% 385.11µs 385.34µs ⚪ 0.06% 🟢 10%
execute/
trunc_f2i
638.38µs 638.33µs ⚪ 0.00% 957.49µs 958.06µs ⚪ 0.06% 🟢 50%
instantiate/
wasm_kernel
55.53µs 55.18µs ⚪ -0.63% 56.39µs 54.47µs 🟢 -3.41% 🟢 -1%
overhead/
call/typed/0
1.24ms 1.28ms 🔴 3.39% 867.60µs 957.92µs 🔴 10.41% 🟢 -25%
overhead/
call/typed/16
1.63ms 1.65ms ⚪ 1.10% 2.53ms 2.77ms 🔴 9.74% 🟡 68%
overhead/
call/untyped/0
1.60ms 1.58ms ⚪ -1.02% 1.20ms 1.23ms 🔴 2.38% 🟢 -23%
overhead/
call/untyped/16
2.41ms 2.44ms ⚪ 1.23% 4.33ms 4.46ms 🔴 3.10% 🟡 83%
translate/
bz2/checked/eager/default
1.33ms 1.32ms ⚪ -0.30% 2.38ms 2.41ms ⚪ 1.11% 🟡 82%
translate/
bz2/checked/eager/fuel
1.43ms 1.43ms ⚪ -0.12% 2.60ms 2.62ms ⚪ 0.77% 🟡 84%
translate/
bz2/checked/lazy-translation/default
545.09µs 543.36µs ⚪ -0.32% 966.05µs 1.07ms 🔴 11.18% 🟡 98%
translate/
bz2/checked/lazy/default
37.03µs 36.94µs ⚪ -0.26% 46.08µs 47.88µs 🔴 3.91% 🟢 30%
translate/
bz2/unchecked/eager/default
1.09ms 1.09ms ⚪ -0.03% 1.83ms 1.84ms ⚪ 0.38% 🟡 69%
translate/
erc1155/checked/eager/default
279.68µs 279.89µs ⚪ 0.08% 470.77µs 473.83µs ⚪ 0.65% 🟡 69%
translate/
erc1155/checked/eager/fuel
301.14µs 301.15µs ⚪ 0.00% 506.70µs 511.54µs ⚪ 0.96% 🟡 70%
translate/
erc1155/checked/lazy-translation/default
128.77µs 128.16µs ⚪ -0.47% 210.96µs 226.90µs 🔴 7.56% 🟡 77%
translate/
erc1155/checked/lazy/default
26.40µs 25.97µs 🟢 -1.62% 33.29µs 34.51µs 🔴 3.67% 🟢 33%
translate/
erc1155/unchecked/eager/default
231.39µs 231.13µs ⚪ -0.11% 361.12µs 366.13µs 🔴 1.39% 🟡 58%
translate/
erc20/checked/eager/default
135.64µs 135.90µs ⚪ 0.20% 226.60µs 227.76µs ⚪ 0.51% 🟡 68%
translate/
erc20/checked/eager/fuel
144.23µs 145.27µs ⚪ 0.72% 239.41µs 241.37µs ⚪ 0.82% 🟡 66%
translate/
erc20/checked/lazy-translation/default
65.17µs 66.68µs 🔴 2.32% 106.36µs 113.98µs 🔴 7.16% 🟡 71%
translate/
erc20/checked/lazy/default
19.39µs 19.25µs ⚪ -0.72% 25.25µs 26.08µs 🔴 3.31% 🟢 35%
translate/
erc20/unchecked/eager/default
110.86µs 111.48µs ⚪ 0.56% 173.36µs 176.18µs 🔴 1.63% 🟡 58%
translate/
erc721/checked/eager/default
193.72µs 193.99µs ⚪ 0.14% 325.82µs 327.77µs ⚪ 0.60% 🟡 69%
translate/
erc721/checked/eager/fuel
204.93µs 205.17µs ⚪ 0.12% 346.53µs 346.24µs ⚪ -0.09% 🟡 69%
translate/
erc721/checked/lazy-translation/default
92.28µs 92.64µs ⚪ 0.38% 151.33µs 163.27µs 🔴 7.89% 🟡 76%
translate/
erc721/checked/lazy/default
23.59µs 23.21µs ⚪ -1.64% 29.65µs 30.34µs 🔴 2.32% 🟢 31%
translate/
erc721/unchecked/eager/default
157.08µs 156.77µs ⚪ -0.20% 246.54µs 249.25µs ⚪ 1.10% 🟡 59%
translate/
pulldown_cmark/checked/eager/default
3.59ms 3.62ms ⚪ 0.74% 6.16ms 6.19ms ⚪ 0.62% 🟡 71%
translate/
pulldown_cmark/checked/eager/fuel
3.89ms 3.89ms ⚪ -0.08% 6.65ms 6.71ms ⚪ 0.93% 🟡 73%
translate/
pulldown_cmark/checked/lazy-translation/default
1.53ms 1.55ms ⚪ 0.82% 2.57ms 2.79ms 🔴 8.44% 🟡 80%
translate/
pulldown_cmark/checked/lazy/default
245.61µs 251.84µs 🔴 2.54% 254.84µs 258.85µs ⚪ 1.58% 🟢 3%
translate/
pulldown_cmark/unchecked/eager/default
3.03ms 3.05ms ⚪ 0.67% 4.80ms 4.83ms ⚪ 0.58% 🟡 58%
translate/
spidermonkey/checked/eager/default
75.75ms 75.93ms ⚪ 0.24% 132.68ms 133.86ms ⚪ 0.89% 🟡 76%
translate/
spidermonkey/checked/eager/fuel
82.75ms 82.42ms ⚪ -0.39% 143.89ms 144.74ms ⚪ 0.59% 🟡 76%
translate/
spidermonkey/checked/lazy-translation/default
32.47ms 32.15ms ⚪ -0.98% 56.01ms 61.21ms 🔴 9.27% 🟡 90%
translate/
spidermonkey/checked/lazy/default
3.21ms 3.24ms ⚪ 0.92% 4.08ms 4.05ms ⚪ -0.73% 🟢 25%
translate/
spidermonkey/unchecked/eager/default
63.04ms 64.05ms 🔴 1.60% 102.68ms 103.70ms ⚪ 0.99% 🟡 62%
translate/
wasm_kernel/checked/eager/default
5.03ms 5.05ms ⚪ 0.31% 8.70ms 8.76ms ⚪ 0.65% 🟡 74%
translate/
wasm_kernel/checked/eager/fuel
5.22ms 5.21ms ⚪ -0.08% 9.18ms 9.21ms ⚪ 0.27% 🟡 77%
translate/
wasm_kernel/checked/lazy-translation/default
2.41ms 2.42ms ⚪ 0.42% 3.97ms 4.26ms 🔴 7.23% 🟡 76%
translate/
wasm_kernel/checked/lazy/default
426.90µs 427.78µs ⚪ 0.21% 496.60µs 499.46µs ⚪ 0.58% 🟢 17%
translate/
wasm_kernel/unchecked/eager/default
4.11ms 4.12ms ⚪ 0.26% 6.61ms 6.64ms ⚪ 0.38% 🟡 61%

Link to pipeline

@Robbepop
Copy link
Member

Robbepop commented Jan 12, 2024

@Thabokani thanks for the typo fixes! :)

I will merge as soon as CI finishes.

@Robbepop
Copy link
Member

Robbepop commented Jan 12, 2024

Note: The clippy CI issue seems to be a bug in clippy since I cannot see how the flagged code can be unconditionally recursive.

rust-lang/rust-clippy#12133

@Robbepop Robbepop merged commit 6d44629 into wasmi-labs:master Jan 12, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants