Test, benchmarks & fixes to UTF-8 validation #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
=======================================
Coverage 99.26% 99.26%
=======================================
Files 74 74
Lines 11439 11441 +2
=======================================
+ Hits 11355 11357 +2
Misses 84 84
Flags with carried forward coverage won't be shown. Click here to find out more.
|
axic
reviewed
Mar 10, 2021
|
|
||
| namespace fizzy::test | ||
| { | ||
| const std::string_view utf8_demo = |
There was a problem hiding this comment.
It is, but reference to a literal is fine.
axic
reviewed
Mar 10, 2021
| @@ -0,0 +1,222 @@ | |||
| // The content of the "UTF-8 encoded sample plain-text file" by Markus Kuhn. | |||
There was a problem hiding this comment.
I could not find the original file, but the content has license id and link to author's home page. Many projects uses this file, including:
There was a problem hiding this comment.
Actually, I have found it at https://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-demo.txt.
axic
reviewed
Mar 10, 2021
| @@ -320,7 +320,7 @@ jobs: | |||
| - run: | |||
| name: "Run codespell" | |||
| command: | | |||
| codespell --quiet-level=4 -I .codespell-whitelist | |||
| codespell --quiet-level=4 --ignore-words .codespell-whitelist --skip 'utf8_demo.cpp' | |||
There was a problem hiding this comment.
It's expanded -I option.
axic
approved these changes
Mar 10, 2021
gumb0
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes 32-bit architecture and dead store fixes.
Also added "UTF-8 encoded sample plain-text file" by Markus Kuhn. Used to testing and benchmarking.