Upgrade dependencies and CI config

.clang-tidy

@@ -1,5 +1,11 @@
+# TODO: The bugprone-implicit-widening-of-multiplication-result is nice,
+#       but current implementation is over-pedantic.
+#       See https://github.com/llvm/llvm-project/issues/52806.
+
 Checks: >
   bugprone-*,
+  -bugprone-easily-swappable-parameters,
+  -bugprone-implicit-widening-of-multiplication-result,
   cert-*,
   -cert-err58-cpp,
   clang-analyzer-*,
@@ -15,11 +21,12 @@ Checks: >
   readability-*,
   -readability-braces-around-statements,
   -readability-else-after-return,
+  -readability-function-cognitive-complexity,
   -readability-implicit-bool-conversion,
   -readability-magic-numbers,
   -readability-named-parameter,
   -readability-qualified-auto,
   -readability-uppercase-literal-suffix,
 
 WarningsAsErrors:  '*'
-FormatStyle:       file
+FormatStyle:       file

.codespell-whitelist

@@ -1 +1,2 @@
 mut
+crate

CMakeLists.txt

@@ -66,7 +66,6 @@ if(CMAKE_CXX_COMPILER_ID MATCHES Clang)
             -Wno-double-promotion
             -Wno-float-equal
             -Wno-padded
-            -Wno-return-std-move-in-c++11
             -Wno-switch-enum
         )
     endif()

circle.yml

@@ -8,16 +8,16 @@ parameters:
 executors:
   linux-gcc-latest:
     docker:
-      - image: ethereum/cpp-build-env:16-gcc-10
+      - image: ethereum/cpp-build-env:17-gcc-11
   linux-clang-latest:
     docker:
-      - image: ethereum/cpp-build-env:16-clang-11
+      - image: ethereum/cpp-build-env:17-clang-13
   macos:
     macos:
       xcode: 11.6.0
   rust:
     docker:
-      - image: cimg/rust:1.49
+      - image: cimg/rust:1.57
 
 commands:
   install_macos_deps:
@@ -720,16 +720,10 @@ workflows:
     unless: <<pipeline.parameters.benchmark>>
     jobs:
       - lint
-      - release-linux:
-          requires:
-            - release-native-linux
+      - release-linux
       - release-native-linux
-      - release-macos:
-          requires:
-            - release-native-macos
-      - release-native-macos:
-          requires:
-            - sanitizers-macos
+      - release-macos
+      - release-native-macos
       - coverage-gcc
       - coverage-clang
       - sanitizers-clang
@@ -739,16 +733,10 @@ workflows:
       - spectest:
           requires:
             - coverage-clang
-      - arm64-linux:
-          requires:
-            - coverage-gcc
+      - arm64-linux
       - bindings-rust
-      - bindings-rust-asan:
-          requires:
-            - bindings-rust
-      - bindings-rust-coverage:
-          requires:
-            - bindings-rust
+      - bindings-rust-asan
+      - bindings-rust-coverage
 
   benchmarking:
     when: <<pipeline.parameters.benchmark>>

cmake/Hunter/config.cmake

@@ -1,8 +1,18 @@
 # Hunter local configuration.
 
+hunter_config(
+    GTest
+    VERSION 1.11.0
+    URL https://github.com/google/googletest/archive/release-1.11.0.tar.gz
+    SHA1 7b100bb68db8df1060e178c495f3cbe941c9b058
+    CMAKE_ARGS
+    HUNTER_INSTALL_LICENSE_FILES=LICENSE
+    gtest_force_shared_crt=TRUE
+)
+
 hunter_config(
     benchmark
-    VERSION 1.5.3
-    URL https://github.com/google/benchmark/archive/v1.5.3.tar.gz
-    SHA1 32655d8796e708439ac5d4de8aa31f00d9dbda3b
+    VERSION 1.6.0
+    URL https://github.com/google/benchmark/archive/v1.6.0.tar.gz
+    SHA1 c4d1a9135e779c5507015ccc8c428cb4aca69cef
 )

lib/fizzy/asserts.cpp

@@ -5,15 +5,17 @@
 #include "asserts.hpp"
 
 #ifdef GCOV
-extern "C" void __gcov_flush();
+/// Explicitly dump coverage counters.
+/// https://gcc.gnu.org/onlinedocs/gcc/Gcov-and-Optimization.html
+extern "C" void __gcov_dump();
 #endif
 
 namespace fizzy
 {
 bool unreachable() noexcept
 {
 #ifdef GCOV
-    __gcov_flush();
+    __gcov_dump();
 #endif
     return false;  // LCOV_EXCL_LINE
 }

test/unittests/parser_expr_test.cpp

@@ -347,7 +347,7 @@ TEST(parser_expr, instr_br_table_as_return)
     */
 
     const auto code_bin = i32_const(0) + "0e00000b"_bytes;
-    const auto [code, _] = parse_expr(code_bin);
+    const auto [code, end] = parse_expr(code_bin);
     EXPECT_THAT(code.instructions,
         ElementsAre(Instr::i32_const, 0, 0, 0, 0, Instr::br_table, /*label_count:*/ 0, 0, 0, 0,
             /*arity:*/ 0, 0, 0, 0, /*code_offset:*/ 22, 0, 0, 0, /*stack_drop:*/ 0, 0, 0, 0,

test/unittests/validation_stack_test.cpp

@@ -734,7 +734,7 @@ TEST(validation_stack, br_table)
     EXPECT_THAT(module->codesec[0].max_stack_height, 2);
 }
 
-TEST(validation_stack, return_)
+TEST(validation_stack, return_1)
 {
     /* wat2wasm
     (func

test/utils/typed_value.hpp

@@ -10,13 +10,13 @@
 namespace fizzy::test
 {
 /// Creates uint64_t value with intention to map it to i64 WebAssembly type.
-inline constexpr uint64_t operator"" _u64(unsigned long long x)
+inline constexpr uint64_t operator""_u64(unsigned long long x)
 {
     return uint64_t{x};  // Guarantees lossless conversion if needed.
 }
 
 /// Creates uint32_t value with intention to map it to i32 WebAssembly type.
-inline constexpr uint32_t operator"" _u32(unsigned long long x)
+inline constexpr uint32_t operator""_u32(unsigned long long x)
 {
     const auto v = static_cast<uint32_t>(x);
     if (v != x)

test/utils/wasm3_engine.cpp

@@ -124,7 +124,7 @@ WasmEngine::Result Wasm3Engine::execute(
 {
     unsigned ret_valid;
     uint64_t ret_value;
-    IM3Function function = reinterpret_cast<IM3Function>(func_ref);
+    auto function = reinterpret_cast<IM3Function>(func_ref);  // NOLINT(performance-no-int-to-ptr)
     auto const result = m3_CallProper(
         function, static_cast<uint32_t>(args.size()), args.data(), &ret_valid, &ret_value);
     if (result == m3Err_none)