You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey this is a great plugin and is helping me solve my issue using typeorm migrations with esbuild. Detailed info here floydspace/serverless-esbuild#328
I have a usecase using https://www.npmjs.com/package/serverless-esbuild where I don't have access to the entryPoints array, but you can provide esbuild plugins https://www.npmjs.com/package/serverless-esbuild#esbuild-plugins. The typeorm migrations files need importing to be available at lambda runtime, but because esbuild doesn't support statically analysing the dynamic imports produced by providing a glob for typeorm migrations option, there needs to be another way to make sure the files are bundled by esbuild.
Hi @mishabruml :) That sounds like a good addition! It would be great if you could make a PR for this with a test covering this case. But do let me know if you run into any problems or if I can help out in any way.
Hey this is a great plugin and is helping me solve my issue using typeorm migrations with esbuild. Detailed info here floydspace/serverless-esbuild#328
I have a usecase using https://www.npmjs.com/package/serverless-esbuild where I don't have access to the
entryPoints
array, but you can provide esbuild plugins https://www.npmjs.com/package/serverless-esbuild#esbuild-plugins. The typeorm migrations files need importing to be available at lambda runtime, but because esbuild doesn't support statically analysing the dynamic imports produced by providing a glob for typeormmigrations
option, there needs to be another way to make sure the files are bundled by esbuild.It would be great if for this plugin you could provide glob patterns via plugin options. I have done a proof of concept here https://github.com/mishabruml/typeorm-playground/blob/master/sls-esbuild-plugins/additionalEntrypointsGlobPlugin.ts which is working for me. I would love to make a PR and include this functionality into your plugin. The
additionalEntrypoints
could simply be added to the GlobPluginOptions interface? And then most of the logic I have implemented should be fairly simple to incorporate.Cheers!
The text was updated successfully, but these errors were encountered: