additionalEntrypoints glob as plugin option #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @waspeer I broke up the unit test file into chunks as I was finding it quite unwieldy and difficult to work with; hope that's ok! I also was unable to use the test runner very easily without making a lot of breaking changes across the rest of your tests so I've used a lot of repeated code, however hopefully this is a bit easier for you to review, and can be abstracted/optimised later? Cheers |
|
Thanks! I appreciate breaking up the test file, it was becoming pretty huge 😅 I have some ideas for refactoring the test runner, but I'll merge this feature first and work on that separately. |
- specify additonal entrypoints via plugin opt - break up unit test file - unit test additonal entrypoints - test: add all tests to config - test: use safe random strings for file and module names - style: remove whitespace
…n-glob into globs-as-option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13