Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

walletSeed is interpreted incorrectly. #41

Closed
bcdev- opened this issue Sep 24, 2016 · 3 comments
Closed

walletSeed is interpreted incorrectly. #41

bcdev- opened this issue Sep 24, 2016 · 3 comments

Comments

@bcdev-
Copy link
Contributor

bcdev- commented Sep 24, 2016 •
edited
Loading

"walletSeed" is interpreted as Base58. This is incorrect. It should be interpreted in exactly the same way as in the webwallet.
For example:

"walletSeed": 4g7jtUbVJ1vpvJynsP8ZphQEt9R8eoQvbqGMzpuFmhAzSyu5kFgT7fDi92hEi1NCnzJ1M3CDLMVGvxcFZXoNXxN9
node: 3MuuBsiZjAkWETNNgY3JdQ7shy1Az8aEQ4Q
testnet.waveswallet.io: 3MySMuhh6QeN3Uejafd37WiEoZqg4PtieHb

Node should try to forge with the same address as a wallet created from that seed. Currently this is not the case.
@ghost
Copy link

ghost commented Sep 24, 2016

duplicate of this issue which I reported some time ago:
wavesplatform/WavesGUI#57

@bcdev-
Copy link
Contributor Author

bcdev- commented Sep 24, 2016

Yep, it's kind of a duplicate. :-)
However, we differ in proposed solutions. You proposed to change .js part and do if(base58).
I propose to change the node part and scrap debase58ing altogether.

@Tolsi
Copy link
Contributor

Tolsi commented Nov 28, 2016

We do not expect do this in the near future. I'll close this issue

@Tolsi Tolsi closed this as completed Nov 28, 2016
alexeykiselev pushed a commit that referenced this issue Jan 23, 2017
@gagarin55
Merge pull request #41 from gagarin55/terms-fixing
054d3b1 
Naming fixes
inozemtsev-roman pushed a commit to localwaves/node that referenced this issue Aug 15, 2018
Merge pull request wavesplatform#41 from xenohunter/master
6968214 
Added EncryptoTel as a verified asset
Tolsi pushed a commit that referenced this issue Oct 31, 2018
@alexeygorobets
Merge pull request #41 from vostokplatform/VST-389-create-contract-tx
62d1bf4 
VST-389 Add Docker smart contract creation transaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tolsi @bcdev-