Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use short SHA as Git reference in packages naming #90

Closed
Tracked by #110
AlexRuiz7 opened this issue Dec 26, 2023 · 1 comment · Fixed by #100
Closed
Tracked by #110

Use short SHA as Git reference in packages naming #90

AlexRuiz7 opened this issue Dec 26, 2023 · 1 comment · Fixed by #100
Assignees
@f-galland
Labels
level/task Task issue type/enhancement Enhancement issue

Comments

@AlexRuiz7
Copy link
Member

Description

The wazuh-indexer packages follow the naming convention defined in https://github.com/wazuh/internal-devel-requests/issues/187:

<SubsystemName>_<VersionNumber>-<Revision>_{<OSName>-<OSVersion>_}<Architecture>_<GitReference>.<PackageType>

Currently, the packages names look as follows:

  • wazuh-indexer_4.9.0-1-x64_4649bc3821d7eb296ca1d4be1465d8bf10a92bc8.rpm
  • wazuh-indexer_4.9.0-1-x64_4649bc3821d7eb296ca1d4be1465d8bf10a92bc8.deb

The commit's SHA used as Git reference makes the names too large. The commit can be equally referenced using a shorter SHA (see https://stackoverflow.com/a/59819441/13918537)
@AlexRuiz7 AlexRuiz7 added level/task Task issue type/enhancement Enhancement issue labels Dec 26, 2023
@wazuhci wazuhci moved this to Backlog in Release 4.9.0 Dec 26, 2023
@AlexRuiz7 AlexRuiz7 mentioned this issue Dec 26, 2023
Closed
8 tasks
@f-galland f-galland self-assigned this Jan 4, 2024
@wazuhci wazuhci moved this from Backlog to In progress in Release 4.9.0 Jan 4, 2024
@wazuhci wazuhci moved this from In progress to Pending review in Release 4.9.0 Jan 4, 2024
@f-galland f-galland mentioned this issue Jan 8, 2024
Merged
7 tasks
@AlexRuiz7
Copy link
Member Author

AlexRuiz7 commented Jan 8, 2024 •
edited
Loading

We are investigating an approach to comply with the wazuh naming convention (see #91) that is likely to resolve this issue as well, taking preference over #100.

@wazuhci wazuhci moved this from Pending review to Blocked in Release 4.9.0 Jan 8, 2024
@AlexRuiz7 AlexRuiz7 mentioned this issue Jan 8, 2024
Closed
14 tasks
@wazuhci wazuhci moved this from Blocked to Pending review in Release 4.9.0 Jan 10, 2024
@wazuhci wazuhci moved this from Pending review to In final review in Release 4.9.0 Jan 10, 2024
@wazuhci wazuhci moved this from In final review to Done in Release 4.9.0 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f-galland f-galland

Labels
level/task Task issue type/enhancement Enhancement issue
Projects
No open projects
Release 4.9.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use short SHA as Git reference in packages naming wazuh/wazuh-indexer
2 participants
@AlexRuiz7 @f-galland