Unify unatteded uninstall check tools and start cluster #1221

myu1d157h0u54nd · 2022-01-29T19:11:39Z

Related issue
Closes #1212

Description

The script needs to be able to do:

Unattended script: check tools (awk, sed, etc.)
A check is needed in the "--start-cluster" case.

…ction checkTools

verdx

LGTM

alberpilot

cores=$(cat /proc/cpuinfo | grep -c processor )
Check if the file exist.

unattended_installer/install_functions/opendistro/checks.sh

unattended_installer/wazuh_install.sh

alberpilot · 2022-02-01T20:25:39Z

unattended_installer/install_functions/opendistro/checks.sh

+                    "tar"
+                    "awk"
+                    "free"
+                    "sed")


Include echo, cat, grep, rm, touch, kill, cp, mv, export, mkdir, curl, chown, sudo, chmod, in the list. Then, don't exit in the first not found command. Instead of this, make a list of not-found dependencies and print the list, avoiding the re-run for every command.

Installation simulation, modifying the list of tools by adding the false commands 'badbad' and 'notsobad'.

sudo bash /tmp/unattended_installer/wazuh_install.sh --local --development --ignore-health-check --disable-spinner --all-in-one

03/02/2022 16:41:02 INFO: ---------------------------------- Missing tool ----------------------------------- 03/02/2022 16:41:02 INFO: Missing tool report: badbad, notsobad, are not installed. All this command's are necessary for the correct use of this tool.

myu1d157h0u54nd · 2022-02-02T04:59:52Z

/proc/cpuinfo

Done!

alberpilot

Please review the requested changes and please attach examples of changes.

unattended_installer/install_functions/opendistro/checks.sh

alberpilot · 2022-02-02T16:29:20Z

unattended_installer/install_functions/opendistro/checks.sh

@@ -308,7 +351,12 @@ function checkPreviousCertificates() {

 function checkSpecs() {

-    cores=$(cat /proc/cpuinfo | grep -c processor )
+    coresFile=/etc/resolv.conf


Suggested change

coresFile=/etc/resolv.conf

coresFile="/proc/cpuinfo"

unattended_installer/install_functions/opendistro/checks.sh

myu1d157h0u54nd · 2022-02-04T18:59:37Z

Simulation of a linux where the file does not exist: /proc/cpuinfo. Using the name /proc/cpuinfoTEST

sudo bash /tmp/unattended_installer/wazuh_install.sh --local --development --disable-spinner --all-in-one

03/02/2022 14:51:58 INFO: Starting Wazuh unattended installer. Wazuh version: 4.3.0. Wazuh installer version: 0.1
03/02/2022 14:51:58 INFO: ---------------------------------- Dependencies -----------------------------------
03/02/2022 14:51:58 INFO: Starting the installation of dependencies.
03/02/2022 14:52:14 INFO: Installation of dependencies finished.
03/02/2022 14:52:30 ERROR: The /proc/cpuinfoTEST does not exist.
03/02/2022 14:52:30 WARNING: The script needs to parse the file '/proc/cpuinfoTEST' to check the minimum required hardware of CPU cores.
03/02/2022 14:52:30 WARNING: Use the --ignore-health-check parameter to dismiss the recommended minimum hardware requirements check.

Continuation of the installation process following the recommendation of the script.
bash /tmp/unattended_installer/wazuh_install.sh --local --development --ignore-health-check --disable-spinner --all-in-one

03/02/2022 14:57:27 INFO: Starting Wazuh unattended installer. Wazuh version: 4.3.0. Wazuh installer version: 0.1
03/02/2022 14:57:27 INFO: ---------------------------------- Dependencies -----------------------------------
03/02/2022 14:57:27 INFO: Starting the installation of dependencies.
03/02/2022 14:57:37 INFO: Installation of dependencies finished.
03/02/2022 14:57:43 WARNING: Health-check ignored.
03/02/2022 14:57:44 INFO: ------------------------------- Configuration files -------------------------------
03/02/2022 14:57:44 INFO: Creating the root certificate.
03/02/2022 14:57:45 INFO: Creating the Elasticsearch certificates.
03/02/2022 14:57:45 INFO: Creating the Wazuh server certificates.
03/02/2022 14:57:45 INFO: Creating the Kibana certificate.
03/02/2022 14:57:45 INFO: Configuration files created: /tmp/unattended_installer/configurations.tar
03/02/2022 14:57:45 INFO: -------------------------- Open Distro for Elasticsearch --------------------------
03/02/2022 14:57:45 INFO: Starting Open Distro for Elasticsearch installation.

…natteded-uninstall-check-tools-and-start-cluster

myu1d157h0u54nd · 2022-02-04T20:40:50Z

Installation simulation, modifying the list of tools by adding the false commands 'badbad' and 'notsobad'.

sudo bash /tmp/unattended_installer/wazuh_install.sh --local --development --ignore-health-check --disable-spinner --all-in-one

03/02/2022 16:41:02 INFO: ---------------------------------- Missing tool -----------------------------------
03/02/2022 16:41:02 INFO: Missing tool report: badbad, notsobad,  are not installed. All this command's are necessary for the correct use of this tool.

alberpilot

Please review the requested changes

alberpilot · 2022-02-07T12:11:32Z

unattended_installer/install_functions/opendistro/checks.sh

+
+    if [ -n "${missingtoolsList}" ]; then
+
+        logger "---------------------------------- Missing tool -----------------------------------"


Suggested change

logger "---------------------------------- Missing tool -----------------------------------"

logger "---------------------------------- Missing tools -----------------------------------"

alberpilot · 2022-02-07T12:13:51Z

unattended_installer/install_functions/opendistro/checks.sh

+    if [ -n "${missingtoolsList}" ]; then
+
+        logger "---------------------------------- Missing tool -----------------------------------"
+        logger "Missing tool report: ${missingtoolsList} are not installed. All this command's are necessary for the correct use of this tool."


Suggested change

logger "Missing tool report: ${missingtoolsList} are not installed. All this command's are necessary for the correct use of this tool."

logger "The following command or commands are not present in the system: ${missingtoolsList} and must it is / they are necessary for the correct use of this tool."

alberpilot · 2022-02-07T12:21:25Z

unattended_installer/wazuh_install.sh

@@ -404,14 +407,6 @@ function main() {
        checkNames
    fi

-# -------------- Prerequisites and Wazuh repo  ----------------------


Is the Dependencies installation uneccesary?

Recovered, this was a mistake

But why is moved before the preliminary steps?
If there is an error with the node names, etc, I prefer to know it before starting installing dependencies.

I am sorry, I do not understand. Tell me if I understand correctly please.
Functions import. Line 332. Check the system tools.
Preliminary checks, Line 345. This step checks arguments and parameters.
Prerequisites and Wazuh repo, Line 375. This step installs dependencies
Preliminary steps, Line 383. It only validates checkPreviousCertificates.
I understand this would be correct.

alberpilot · 2022-02-07T13:07:39Z

unattended_installer/install_functions/opendistro/checks.sh

-            logger "Check recommended minimum hardware requirements for Elasticsearch done."
-        fi
+    if [ -z "${cores}" ]; then
+        logger -w "The script needs to parse the file '${coresFile}' to check the minimum required hardware of CPU cores."


If you plan to exit from the script run, this message is not a warning but an error. Only errors should be able to exit from a run.

unattended_installer/install_functions/opendistro/checks.sh

alberpilot · 2022-02-07T13:10:02Z

unattended_installer/install_functions/opendistro/checks.sh

+        exit 1
+    fi
+    if [ -z "${ram_gb}" ]; then
+        logger - w "The command 'free' is required to check the minimum required hardware of RAM."


Another point: is there any way to reach this code without free installed?
I like the idea of ${ram_gb} not valid value management, but I don't think the message could happen in any situation.

If the free command was not installed. /proc/meminfo can be used
Although I did not imagine a possible scenario where free was not installed, I preferred to add this check, in case there were any cases.
When I did some research later I found that free and other commands come specifically from a package.

https://www.linux.co.cr/ldp/lfs/appendixa/procps.html

PS: I add a workarrond for the stage that free is not.

…eckTools (order a-z)

…natteded-uninstall-check-tools-and-start-cluster

This PR has new commit!

alberpilot

Please review the requested changes

alberpilot · 2022-02-08T12:03:52Z

unattended_installer/install_functions/opendistro/checks.sh

+            MEMinKB=$(cat "$memFile" | grep MemTotal | awk '/^MemTotal:/{print $2}')
+            ram_gb=$(( $MEMinKB / 1024 ))
+        else
+            logger -e "The $coresFile does not exist."


Why $coresFile?

Done 2761821

alberpilot · 2022-02-08T12:05:44Z

unattended_installer/wazuh_install.sh

@@ -404,14 +407,6 @@ function main() {
        checkNames
    fi

-# -------------- Prerequisites and Wazuh repo  ----------------------


But why is moved before the preliminary steps?
If there is an error with the node names, etc, I prefer to know it before starting installing dependencies.

alberpilot · 2022-02-08T12:08:48Z

unattended_installer/install_functions/opendistro/checks.sh

+    if [ -n "${missingtoolsList}" ]; then
+
+        logger "---------------------------------- Missing tools -----------------------------------"
+        logger "The following command or commands are not present in the system: ${missingtoolsList} and must it is / they are necessary for the correct use of this tool."


Suggested change

logger "The following command or commands are not present in the system: ${missingtoolsList} and must it is / they are necessary for the correct use of this tool."

logger "The following command or commands are not present in the system: ${missingtoolsList}. Those tools are necessary for the correct use of this tool."

Done 2761821

myu1d157h0u54nd · 2022-02-09T05:38:58Z

Pending conflict resolution!

myu1d157h0u54nd added 2 commits January 29, 2022 16:04

Fix use of rollBack with overwrite, start_elastic_cluster and add fun…

4b8cda9

…ction checkTools

Add function checkTools and fix initial stage flow

4530295

myu1d157h0u54nd requested review from alberpilot, DFolchA and verdx January 29, 2022 19:11

myu1d157h0u54nd self-assigned this Jan 29, 2022

verdx previously approved these changes Jan 31, 2022

View reviewed changes

Remove unnecessary eval.

dcdd5e3

alberpilot suggested changes Feb 1, 2022

View reviewed changes

myu1d157h0u54nd added 3 commits February 2, 2022 01:38

fix function checkTools

c79f38e

fix merge conflict

e845bd4

fix checkSpecs (coresFile)

78c6d9a

myu1d157h0u54nd requested review from alberpilot and verdx February 2, 2022 06:03

alberpilot suggested changes Feb 2, 2022

View reviewed changes

myu1d157h0u54nd added 2 commits February 4, 2022 16:19

Fix function checkArguments (Cluster start), function checkHealth

9579597

Merge branch 'unify-unatteded-uninstall-chose-component' into unify-u…

346f192

…natteded-uninstall-check-tools-and-start-cluster

myu1d157h0u54nd requested a review from alberpilot February 4, 2022 20:36

alberpilot suggested changes Feb 7, 2022

View reviewed changes

myu1d157h0u54nd added 3 commits February 8, 2022 00:55

Fix checkHealth (logger), fix checkSpecs (free use for check ram), ch…

2decde4

…eckTools (order a-z)

Restore call to: Prerequisites and Wazuh repo

75ae8a8

Merge branch 'unify-unatteded-uninstall-chose-component' into unify-u…

d7595e0

…natteded-uninstall-check-tools-and-start-cluster

myu1d157h0u54nd requested a review from alberpilot February 8, 2022 03:59

alberpilot suggested changes Feb 8, 2022

View reviewed changes

Fix logger

2761821

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unify unatteded uninstall check tools and start cluster #1221

Unify unatteded uninstall check tools and start cluster #1221

myu1d157h0u54nd commented Jan 29, 2022 •

edited

Loading

verdx left a comment

alberpilot left a comment

alberpilot Feb 1, 2022

myu1d157h0u54nd Feb 2, 2022

myu1d157h0u54nd Feb 4, 2022

myu1d157h0u54nd commented Feb 2, 2022

alberpilot left a comment •

edited

Loading

alberpilot Feb 2, 2022

myu1d157h0u54nd commented Feb 4, 2022 •

edited

Loading

myu1d157h0u54nd commented Feb 4, 2022

alberpilot left a comment

alberpilot Feb 7, 2022

myu1d157h0u54nd Feb 8, 2022

alberpilot Feb 7, 2022

myu1d157h0u54nd Feb 8, 2022

alberpilot Feb 7, 2022

myu1d157h0u54nd Feb 8, 2022

alberpilot Feb 8, 2022

myu1d157h0u54nd Feb 9, 2022

alberpilot Feb 7, 2022

myu1d157h0u54nd Feb 8, 2022

alberpilot Feb 7, 2022

myu1d157h0u54nd Feb 8, 2022

alberpilot left a comment

alberpilot Feb 8, 2022

myu1d157h0u54nd Feb 9, 2022

alberpilot Feb 8, 2022

alberpilot Feb 8, 2022

myu1d157h0u54nd Feb 9, 2022

myu1d157h0u54nd commented Feb 9, 2022


		if [ -n "${missingtoolsList}" ]; then

		logger "---------------------------------- Missing tool -----------------------------------"

	logger "Missing tool report: ${missingtoolsList} are not installed. All this command's are necessary for the correct use of this tool."
	logger "The following command or commands are not present in the system: ${missingtoolsList} and must it is / they are necessary for the correct use of this tool."

Unify unatteded uninstall check tools and start cluster #1221

Are you sure you want to change the base?

Unify unatteded uninstall check tools and start cluster #1221

Conversation

myu1d157h0u54nd commented Jan 29, 2022 • edited Loading

Description

verdx left a comment

Choose a reason for hiding this comment

alberpilot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

myu1d157h0u54nd commented Feb 2, 2022

alberpilot left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

myu1d157h0u54nd commented Feb 4, 2022 • edited Loading

myu1d157h0u54nd commented Feb 4, 2022

alberpilot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alberpilot left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

myu1d157h0u54nd commented Feb 9, 2022

myu1d157h0u54nd commented Jan 29, 2022 •

edited

Loading

alberpilot left a comment •

edited

Loading

myu1d157h0u54nd commented Feb 4, 2022 •

edited

Loading