This repository has been archived by the owner on Nov 9, 2024. It is now read-only.
Update to support mongoose > 7 #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s), package is type module (ESM)
|
Hey, I'm archiving this repo, as it no longer relevant (for me, I probably for the whole ecosystem). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mongoose 7 and above no longer supports callbacks on queries - see https://mongoosejs.com/docs/migrating_to_7.html#dropped-callback-support
This PR updates mongoose-fill to work with that change, as well as updating dependencies, and converting the whole module to ESM with no more use of babel.
A further rewrite to change the fill functions to use promises themselves instead of callbacks would be advisable, but that would introduce further breaking changes for consumers of the library. I may look at doing another PR in future to do that.