From 2197c216464fa254ef3c264a5db9d59aff0b497b Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Wed, 23 Dec 2020 11:30:51 +0000 Subject: [PATCH 1/2] Mark Run() as helper function So failure will be reported on the line of the caller --- e2e/util/command.go | 1 + 1 file changed, 1 insertion(+) diff --git a/e2e/util/command.go b/e2e/util/command.go index 9f14edc34..dd95bba42 100644 --- a/e2e/util/command.go +++ b/e2e/util/command.go @@ -72,6 +72,7 @@ func (c *Command) Dir(path string) *Command { // on encountering an error, call Command.Cmd.CombinedOutput() or the // appropriate method to execute the command separately. func (c *Command) Run() { + c.T.Helper() out, err := c.Cmd.CombinedOutput() assert.Check(c.T, err, fmt.Sprintf("cmd: \n%q\n%s", c.Cmd, out)) if err != nil { From 68db649cd8e30c08127506216ae7e31b032ac8e5 Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Wed, 23 Dec 2020 11:31:18 +0000 Subject: [PATCH 2/2] Fix typos --- e2e/util/command.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/e2e/util/command.go b/e2e/util/command.go index dd95bba42..e2e99dd76 100644 --- a/e2e/util/command.go +++ b/e2e/util/command.go @@ -13,8 +13,8 @@ const ( ) // Command is an ignite command execution helper. It takes a binary and the -// arguments to run with the binary. It provides a chaining methods to -// fascilitate easy construction of the command. +// arguments to run with the binary. It provides chaining methods to +// facilitate easy construction of the command. type Command struct { bin string T *testing.T