-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace threading.Lock
with asyncio.Lock
when batching to avoid deadlocks
#1270
base: main
Are you sure you want to change the base?
Conversation
…implicit 3.{8,9} behaviour
…te/weaviate-python-client into fix-deadlocks-in-batching
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
- Coverage 94.38% 93.93% -0.45%
==========================================
Files 220 221 +1
Lines 20956 21302 +346
==========================================
+ Hits 19779 20010 +231
- Misses 1177 1292 +115 ☔ View full report in Codecov by Sentry. |
Great to see you again! Thanks for the contribution. |
…ient into fix-deadlocks-in-batching
Closing in favour of #1371 |
…ient into fix-deadlocks-in-batching
threading.Lock
s inasync def
fns toasyncio.Lock
to avoid blocking the event looptime.sleep()
s inasync def
fns toasyncio.sleep()
to avoid blocking the event loopBatchObject
instead of_BatchObject
inErrorObject
andBatchReference
instead of_BatchReference
inErrorReference
for easier usage of errors